Preserve typed prepaint block variants - #45
Open
isomorphisms wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erased distinction
The
ib-prepaintparser already validates six block records, their exact field counts, nonempty rows, and heading levels 1–6. It then discarded that result intokind: String,level: int, and an arbitrary positionalList<String>. The Android renderer had to recover the variant with a string switch and unchecked indexes.Change
SourceKind;HeadingLevelestablished by the wire parser;Blockpayload with a closed family ofHeadingBlock,TextBlock,LinkBlock,RowBlock,FormBlock, andImageBlock, each carrying only its own named fields;completeproposition primitive.The interchange grammar and painted behavior do not change. This is the Android adapter retaining information that the existing parser has already proved, not a new browser type hierarchy.
Newly rejected
The checked-in refusal fixtures compile those first two invalid consumers and require the compiler to reject them.
Verification
Exact branch head:
c7f5ea96e260e8ff4f0f774fd0d3a60752a6f8bbLocal:
GitHub Actions remains responsible for the Android SDK unit/lint/APK path.