Skip to content

Fix OIDC release authentication setup - #120

Merged
itsjling merged 1 commit into
mainfrom
codex/fix-release-oidc-auth
Sep 1, 2026
Merged

Fix OIDC release authentication setup#120
itsjling merged 1 commit into
mainfrom
codex/fix-release-oidc-auth

Conversation

@itsjling

@itsjling itsjling commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • stop setup-node from generating token-auth configuration in the protected OIDC publish job
  • preserve the explicit npm registry used by all release lookups and publishing
  • pin the tokenless workflow invariant with a regression assertion

Failure

The 0.11.0 release run passed preparation, then failed before any Git or npm mutation because setup-node v6 injected its placeholder NODE_AUTH_TOKEN when registry-url was configured. The finalizer intentionally rejects token authentication. The failed run left both v0.11.0 and diffsplain@0.11.0 absent.

Verification

  • corepack pnpm run check
  • pnpm test
  • node --test tests/release-workflow.test.mjs tests/automation-trust.test.mjs
  • pnpm exec fallow audit --root . --format json --changed-since origin/main
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T13:35:25.270082Z 00d2f21 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@itsjling itsjling added the automation-reviewed Repo-owned automation changes were reviewed label Sep 1, 2026
@itsjling

itsjling commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 00d2f21da7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling
itsjling merged commit 7694b4d into main Sep 1, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation-reviewed Repo-owned automation changes were reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant