Implement allocator support for protocol - #160
Open
RyanJK5 wants to merge 13 commits into
Open
Conversation
RyanJK5
marked this pull request as draft
August 23, 2026 06:16
Collaborator
Author
|
@jbcoe Hey, sorry to request review early, it did it automatically when I opened the PR. I will split away a PR that corrects some behavior and compiler errors from the If you think the actual implementation of protocol should be split, let me know. It's not an unreasonable instinct, but the tutorials may already explain a good amount of the implementation. |
Owner
|
Apology not needed and never needed, just switch it back to draft if you
change your mind.
GitHub tools are designed for high cost, low trust, low competence
collaboration (that’s wise as it’s the riskier setup). We’re zero cost,
high trust (and growing) and high competence (so long as I don’t try and
submit more unreviewed agentic code).
I’ll take a look when you’re ready.
…On Sun, 23 Aug 2026 at 07:20, Ryan Keane ***@***.***> wrote:
*RyanJK5* left a comment (jbcoe/cc-protocol#160)
<#160 (comment)>
@jbcoe <https://github.com/jbcoe> Hey, sorry to request review early, it
did it automatically when I opened the PR. I will split away a PR that
corrects some behavior and compiler errors from the allocator_tests.cc
file, then stack the protocol implementation on that and comment the tests
out.
If you think the actual implementation of protocol should be split, let me
know. It's not an unreasonable instinct, but the tutorials may already
explain a good amount of the implementation.
—
Reply to this email directly, view it on GitHub
<#160?email_source=notifications&email_token=AAF5ZE7JD2DRSXBBIMDFRQL5LKEKDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZYGQ2TSMJYGQ2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5384591844>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF5ZE7SVGHFIBAKHNNW4QD5LKEKDAVCNFSNUABGKJSXA33TNF2G64TZHMYTCMBQGEZTGOBTGY5US43TOVSTWNJSGI2TMMRQGQ2DJILWAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
RyanJK5
force-pushed
the
allocator-impl
branch
from
August 23, 2026 16:28
04d530c to
1807055
Compare
RyanJK5
marked this pull request as ready for review
August 26, 2026 02:05
jbcoe
approved these changes
Aug 27, 2026
jbcoe
left a comment
Owner
There was a problem hiding this comment.
This looks great. Perfectly aligned with the tutorial and very easy to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic allocator support to
protocoland adds allocator_tests.cc to the suite. Disables tests as appropriate to demonstrate the capabilities added in this PR.The implementation essentially fuses the allocator and type erasure tutorials.
Closes #157