Skip to content

Implement allocator support for protocol - #160

Open
RyanJK5 wants to merge 13 commits into
mainfrom
allocator-impl
Open

Implement allocator support for protocol#160
RyanJK5 wants to merge 13 commits into
mainfrom
allocator-impl

Conversation

@RyanJK5

@RyanJK5 RyanJK5 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Adds basic allocator support to protocol and adds allocator_tests.cc to the suite. Disables tests as appropriate to demonstrate the capabilities added in this PR.

The implementation essentially fuses the allocator and type erasure tutorials.

Closes #157

@RyanJK5
RyanJK5 requested a review from jbcoe as a code owner August 23, 2026 06:16
@RyanJK5
RyanJK5 marked this pull request as draft August 23, 2026 06:16
@RyanJK5

RyanJK5 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

@jbcoe Hey, sorry to request review early, it did it automatically when I opened the PR. I will split away a PR that corrects some behavior and compiler errors from the allocator_tests.cc file, then stack the protocol implementation on that and comment the tests out.

If you think the actual implementation of protocol should be split, let me know. It's not an unreasonable instinct, but the tutorials may already explain a good amount of the implementation.

@jbcoe

jbcoe commented Aug 23, 2026 via email

Copy link
Copy Markdown
Owner

@RyanJK5
RyanJK5 marked this pull request as ready for review August 26, 2026 02:05
@RyanJK5 RyanJK5 changed the title DRAFT: Implement allocator support for protocol Implement allocator support for protocol Aug 26, 2026

@jbcoe jbcoe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Perfectly aligned with the tutorial and very easy to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add core allocator implementation

2 participants