Allocator implementation changes - #177
Open
jbcoe wants to merge 18 commits into
Open
Conversation
The reflection tutorial covers reflection features that we will use for the reflection implementation.
Owner
Author
|
@RyanJK5 feel free to just fork this and continue work on the fork if it makes rebasing/merging easier. |
Collaborator
I think merging this makes sense. It's hard to see exactly what changed due to the sheer volume, but if it's just pulling everything from main that makes sense to me. I see it still has merge conflicts - is there anything I can do to help? Would it be better to just manually rewrite the PR off of #168 ahead of time? Not to rewrite the whole thing of course, just to copy over the details into however it best fits with the existing model. I am starting to see why you suggested making changes asynchronously could be difficult :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor fixes and a rebase onto latest main for @RyanJK5 s allocator implementation.