fix(manpage): render mount synopses and custom command names - #1395
Conversation
Entire-Checkpoint: 01M1VTK7JH5HN8DV675CEKKM7P
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation model now carries custom subcommand value names and mount synopses. Manpage rendering uses both values in command synopses and detail sections. Tests cover required and optional placeholders and root and nested mount synopses. ChangesManpage synopsis rendering
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to Manpages now show configured subcommand names and declarative mount synopses, including for commands documented only by mounts. The change is covered for root and nested commands and is ready to merge. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Complete the man-page side of #1393, found while integrating the merged documentation fixes into mise#12889. The man-page renderer builds its own synopsis from the documentation model; that model previously discarded custom subcommand names and unresolved mount fragments.
Please include this in the release tracked by #1389 before mise switches to published dependencies.
Validation: 16 focused man-page tests, including required/optional custom names, root mounts, and mount-only commands whose discovery executable does not exist.
All 785 usage-lib unit tests and Clippy with all features/targets and warnings denied also pass.
AI-generated with Codex.
Note
Low Risk
Documentation-only changes to the docs model and man-page renderer; no runtime CLI or discovery behavior.
Overview
The documentation model now keeps
subcommand_value_nameand declarativemount_synopses(from each mount’ssynopsis, without running discovery), which the man-page renderer previously dropped when building its own synopsis.Man pages use the custom subcommand placeholder instead of hard-coded
<COMMAND>/[COMMAND], append mount synopsis fragments to root and per-command usage lines, and emit a subcommand detail section when the only documentation is a mount synopsis. A regression test covers required/optional custom names, root vs nested mounts, and non-executable discovery targets.Reviewed by Cursor Bugbot for commit 37a9747. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit