Phase 1+2: CRAN-readiness baseline and code quality modernization - #46
Merged
Conversation
Phase 1 (CRAN-readiness): - R-001: Fix invalid POSIXct timestamps in age_calc examples - R-002: Document leading_zero mixed-sign behavior in @details - R-003: Add testthat (>= 3.0.0) version constraint - CI-001: Bump actions/checkout@v3 → v4 Phase 2 (Code quality and test modernization): - R-004: Fix typo 'his' → 'This' in age_calc @description - R-005: Guard readline() with interactive() in autoplot.lm - R-006: Fix stringsAsFactors=TRUE → FALSE in moves_calc - R-007: Fix retained_calc: eliminate caller mutation, remove I() wrapper - R-008: Modernize test-gelmansim.R to testthat 3 API - R-009: Modernize test-utils.R to testthat 3 API - R-010: Remove dead zzz.R, move @importFrom to package file - R-011: Delete commented-out dead code in proficiency_tools.R - GH-28: Cannot reproduce title bug (fixed in prior vcd update) - D-002: Update README.Rmd to github_document output format - D-003: Use packageVersion() in startup message - D-004: Remove 'still in beta' from package docs Also: add packageVersion to utils import (fixes R CMD check NOTE)
- Add trailing newline to R/moves_calc.R (avoids R CMD CHECK NOTE) - Add ^docs$ to .Rbuildignore (exclude planning docs from CRAN tarball) - Add error-on: '"error"' to CI check-r-package step (CI-001 complete) - Mark D-004 and CI-001 as done in issue backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 (CRAN-readiness):
Phase 2 (Code quality and test modernization):
Also: add packageVersion to utils import (fixes R CMD check NOTE)