Skip to content

Should depend on ipykernel #149

Description

@juliangilbey

It turns out that unittest's behaviour for subclasses is interesting: it appears to call the setUpClass method for both the subclass and the superclass. So when subclassing KernelTests for testing a kernel, and setting kernel_name as a class variable in the subclass, the setUpClass method in KernelTests is called both for this subclass with its specified kernel_name but also for jupyter_kernel_test.KernelTests itself, with kernel_name == "python3". This therefore requires ipykernel to be installed, otherwise the test fails with an error (python3 kernel not found).

The simplest solution appears to be to depend on ipykernel, so that the python3 kernel is guaranteed to be present when using this package.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions