Skip to content

PTV-1930 fix datatable error when data is missing from FeatureClusters object - #3740

Merged
briehl merged 2 commits into
developfrom
PTV-1930-noisy-datatable
Aug 11, 2026
Merged

PTV-1930 fix datatable error when data is missing from FeatureClusters object#3740
briehl merged 2 commits into
developfrom
PTV-1930-noisy-datatable

Conversation

@briehl

@briehl briehl commented Aug 11, 2026

Copy link
Copy Markdown
Member

Description of PR purpose/changes

When data (specifically the type field) is missing from FeatureClusters object info - or, rather, the linked features from the genome object - a null value gets fed into the datatable. Datatables doesn't like that and whines whenever it gets rendered. There's probably a config to stop that, but other parts of that viewer expect to put in a dash for a missing value, so this column now does that, too.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/PTV-1930

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

Will bump version in next PR for a new release.

@sonarqubecloud

Copy link
Copy Markdown

@briehl

briehl commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Other than the default "can this load" smoke test, there are no unit tests for that widget. IMO it's a little out of scope to build a unit test suite in this case. But I can if you prefer.

@briehl
briehl requested a review from ialarmedalien August 11, 2026 16:19
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.93%. Comparing base (8b47954) to head (33d65f7).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../function_output/kbaseExpressionFeatureClusters.js 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3740      +/-   ##
===========================================
- Coverage    25.94%   25.93%   -0.01%     
===========================================
  Files          461      461              
  Lines        46700    46701       +1     
===========================================
- Hits         12116    12113       -3     
- Misses       34584    34588       +4     
Files with missing lines Coverage Δ
.../function_output/kbaseExpressionFeatureClusters.js 0.99% <0.00%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3f394...33d65f7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@briehl
briehl merged commit e6c4e1e into develop Aug 11, 2026
14 of 16 checks passed
@briehl
briehl deleted the PTV-1930-noisy-datatable branch August 11, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants