You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When data (specifically the type field) is missing from FeatureClusters object info - or, rather, the linked features from the genome object - a null value gets fed into the datatable. Datatables doesn't like that and whines whenever it gets rendered. There's probably a config to stop that, but other parts of that viewer expect to put in a dash for a missing value, so this column now does that, too.
Other than the default "can this load" smoke test, there are no unit tests for that widget. IMO it's a little out of scope to build a unit test suite in this case. But I can if you prefer.
❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.93%. Comparing base (8b47954) to head (33d65f7). ⚠️ Report is 1 commits behind head on develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
When data (specifically the
typefield) is missing from FeatureClusters object info - or, rather, the linked features from the genome object - anullvalue gets fed into the datatable. Datatables doesn't like that and whines whenever it gets rendered. There's probably a config to stop that, but other parts of that viewer expect to put in a dash for a missing value, so this column now does that, too.Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/PTV-1930
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)
Will bump version in next PR for a new release.