fix(activity): show selected watch-only wallet transaction history - #461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
In watch-only mode, Activity still queried the live wallet scope. With no device connected it returned no rows, and Rescan tried to derive addresses over USB, so the selected saved wallet appeared to have no transaction history.
Activity and asset previews now read the selected snapshot's wallet-scoped rows. Rescan uses its saved public addresses and Bitcoin account xpubs without device derivation. The snapshot is checked again before writes, so a wallet switch or hidden session cannot attach results to another wallet. Bitcoin-only snapshots use a stable scope derived from their saved xpubs because they have no Ethereum seed address. Failed scans show an error instead of “Up to date.” A saved swap can open read-only details in watch-only mode.
Validation
developworktree.git diff --checkpasses.Limits
src/bun/index.tsif the swap settlement PR merges first.