Skip to content

update type hints for better Python compatibility - #560

Closed
zoumingzhe wants to merge 2 commits into
kislyuk:mainfrom
bondbox:develop
Closed

zoumingzhe wants to merge 2 commits into
kislyuk:mainfrom
bondbox:develop

Conversation

@zoumingzhe

Copy link
Copy Markdown
Contributor
class ChoicesCompleter(BaseCompleter):
  choices: Final[Mapping[str, str | bytes]]

E TypeError: unsupported operand type(s) for |: 'type' and 'type'

/root/.pyenv/versions/3.9.18/lib/python3.9/site-packages/argcomplete/completers.py:35: TypeError

Signed-off-by: Mingzhe Zou <zoumingzhe@qq.com>
Signed-off-by: Mingzhe Zou <zoumingzhe@qq.com>
@zoumingzhe zoumingzhe mentioned this pull request Aug 5, 2026
@kislyuk

kislyuk commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Thank you for your PR. I appreciate the effort; unfortunately I won't be merging it in its current form because we will not be supporting EOL Python versions.

@kislyuk kislyuk closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants