chore: add pr template - #7
Open
maciejmajek wants to merge 1 commit into
Open
maciejmajek wants to merge 1 commit into
maciejmajek wants to merge 1 commit into
Conversation
# What <!-- What did you change? What did you add?--> # Why <!-- Reason for changes --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] feat: A new feature - [ ] fix: A bug fix - [ ] docs: Documentation only changes - [ ] style: Changes that do not affect the meaning of the code - [ ] refactor: A code change that neither fixes a bug nor adds a feature - [ ] perf: A code change that improves performance - [ ] test: Adding missing tests or correcting existing tests - [ ] ci: Changes to our CI configuration files and scripts - [x] chore: Other changes that don't modify src or test files - [ ] revert: Reverts a previous commit # How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [ ] Unit test - [ ] Integration test ## Notes for reviewer
maciejmajek
requested review from
niemiaszek
and removed request for
niemiaszek
August 17, 2023 19:52
Contributor
|
Hm, seems like a bit much for our project. I guess I would remove "How Has This Been Tested?" - if we setup CI/CD we should get this info directly from Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: rebase when #6 is merged
What
Pull request template
Why
For better clarity & project management
Type of change
How Has This Been Tested?
Notes for reviewer