fix(icons): add Tabler icon support DEV-2929 - #582
Merged
Merged
Conversation
jamesrkiger
requested review from
magicznyleszek
and
a lite review from Copilot
September 23, 2026 13:28
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate locale-registration and icon-validation issues remain, along with documentation and generated-output consistency nits.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (5)
What changed in this PR
Adds Tabler outline and filled icon support alongside existing k-icons using subsetted webfonts and generated CSS assets.
Changes:
- Adds Tabler icon allow-listing, dependencies, and generation scripts.
- Registers generated fonts and shared styling.
- Updates documentation and dashboard icon usage.
| File | Summary |
|---|---|
source/language_dashboard.md |
Uses a Tabler icon; no findings. |
source/conf.py |
Loads Tabler styles for English docs. Moderate (2 votes): also register both stylesheets for Spanish and French builds. |
source/_static/tabler-icons/tabler-outline.css |
Generated Tabler outline stylesheet; no findings. |
source/_static/tabler-icons/tabler-filled.css |
Generated Tabler filled stylesheet; no findings. |
source/_static/css/kobo_theme.css.map |
Updated compiled source map; no findings. |
source/_static/css/kobo_theme.css |
Includes compiled Tabler styles; no findings. |
scripts/tabler-icons-list.json |
Defines the supported Tabler icons; no findings. |
scripts/generate_icons.js |
Generates subsetted fonts and CSS. Moderate (2 votes): fail when requested icons are missing instead of silently filtering them. Nit (2 votes): keep generated URL quoting consistent with committed CSS. |
sass_source/sass/_icons.scss |
Adds shared Tabler icon styling; no findings. |
README.md |
Documents icon usage. Nits: fix commandd to command (3 votes) and clarify the heading to show the required two-class form (2 votes). |
package.json |
Adds Tabler and subsetting dependencies; no findings. |
Files not reviewed (1)
- source/_static/css/kobo_theme.css: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixed a typo in the README regarding the inspect command. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jamesrkiger
requested review from
pauloamorimbr
and removed request for
magicznyleszek
September 23, 2026 14:51
pauloamorimbr
approved these changes
Sep 24, 2026
pauloamorimbr
left a comment
There was a problem hiding this comment.
LGTM!
There are some unrelated syntax fixing deleting empty spaces, but I'm fine with that! Well done. Tested and icons appear properly after building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


📣 Summary
Adds support for Tabler icons in doc articles alongside the existing KPI icon set.
💭 Notes
This change ensures doc writers can reference both our legacy icons and Tabler icons inline in articles using the same
<i class="...">pattern already used for k-icons.How it works:
k-iconsare unchanged — generated from SVGs in the KPI repo via fantasticon as before@tabler/icons-webfont) down to a specified (manually set) list of icons KPI currently uses inscripts/tabler-icons-list.jsonsubset-font) was chosen over generating from SVGs because Tabler's outline icons are stroke-based and don't convert correctly to a font format via fantasticon — the webfont package has already done that conversion properlynpm installUsage in articles:
To verify this works, build the site and view the language_dashboard page. The k-icon-language icon has been replaced by the tabler world icon (will fix the other instances of this icon in a separate PR).