Fixed(application-graph): log application init and release time in milliseconds - #858
Open
salatmaster wants to merge 1 commit into
Open
Fixed(application-graph): log application init and release time in milliseconds#858salatmaster wants to merge 1 commit into
salatmaster wants to merge 1 commit into
Conversation
…lliseconds
`KoraApplication` divided a `System.nanoTime()` delta by 1000, so both
"Application initialized in {}ms" and "Application released in {}ms"
reported microseconds while labeling them as milliseconds.
Closes kora-projects#854
Dependency Update ReportUpdate level: Found
|
GoodforGod
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #854
KoraApplicationделило разницуSystem.nanoTime()на 1000, то есть считало микросекунды, а в лог писалоms. Теперь используетсяDuration.ofNanos(...).toMillis().Было:
Стало:
То же самое исправлено в
Application released in {}ms.EN:
KoraApplicationdivided aSystem.nanoTime()delta by 1000, so both the init and the release log lines reported microseconds while labeling them as milliseconds.