Skip to content

Suppress the gosec G704 SSRF false positive in Client.Do #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korya merged 1 commit into from
Aug 7, 2026
Merged

Suppress the gosec G704 SSRF false positive in Client.Do #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,10 @@ func (c Client) Do(req *http.Request, assertions ...Assertion) error {

c.logInfo("[.] %s %s %s", req.Proto, req.Method, req.URL)
startedAt := time.Now()
res, err := c.getHttpClient().Do(req)
// G704: the request URL comes from the operator's own command line, and
// fetching it is the entire purpose of this tool -- no trust boundary is
// crossed, so this is not SSRF.
res, err := c.getHttpClient().Do(req) // #nosec G704 - user asked for this URL
if err != nil {
var b strings.Builder
fmt.Fprintf(&b, "failed to send request:\n- %s\n", err)
Expand Down Expand Up @@ -356,7 +359,7 @@ func (c Client) getHttpClient() *http.Client {
},
}
if c.SkipSslChecks {
tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} // #nosec G402 - user askef for it
tr.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} // #nosec G402 - user asked for it
}

return &http.Client{
Expand Down
Loading