Skip to content

Interface to property::parse and property::validate should be streamlined #369

Description

@kpeeters

This is a problem when property declarations want to insert other property declarations. The correct place to do this is in validate (as that is the last function which gets called before the property is inserted). However, this function accepts a reference to the Ex, and inject_property takes a shared pointer. Right now Indices gets around this by adding the Integer property in the parse function, but that is risky because in principle the validate could fail, and then the Integer property is inserted but the Indices is not. This needs to be cleaned up, unified and documented.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugAn actual bugdocumentationMissing, incorrect or confusing documentationenhancementNot strictly a bug but more of a feature enhancement request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions