Skip to content

feat: update plugin version handling and improve logging - #31

Merged
nil-malh merged 1 commit into
mainfrom
feat/plugin-version-resolver
Sep 20, 2026
Merged

nil-malh merged 1 commit into
mainfrom
feat/plugin-version-resolver

Conversation

@nil-malh

Copy link
Copy Markdown
Contributor

📝 Description

This PR updates the notifications plugin to match the current ktestify-core API and fixes runtime version reporting for the plugin.

The main changes are:

• upgrade io.github.ktestify:ktestify-core from 1.0.3 to 1.1.2
• replace the hard-coded plugin version with PluginVersionResolver.resolve(...)
• add filtered resource handling so plugin-version.properties is included in the built artifact
• clean up plugin startup/shutdown logging for clearer output

This keeps the plugin version aligned with the actual build metadata and avoids stale version values when loaded at runtime.


🔄 Type of Change

  • 🐛 Bug fix — non-breaking change that fixes an issue
  • New feature — non-breaking change that adds functionality
  • 💥 Breaking change — fix or feature that changes existing behaviour
  • ♻️ Refactoring / technical debt — no functional change
  • 📖 Documentation — doc-only changes
  • ⬆️ Dependency update — bumped library/plugin version(s)
  • 🔧 CI / build — changes to workflows, pom.xml, tooling

✅ Pre-Merge Checklist

Code Quality

  • My code follows the Palantir Java Format style (passes mvn spotless:check)
  • I have added or updated Javadoc on public types and methods

Tests

  • I have added unit tests that cover the new / changed behaviour
  • All existing and new tests pass locally (mvn verify)
  • JaCoCo line coverage ≥ 70 % is maintained
  • Tests using Testcontainers are isolated and do not leave containers running

Licensing

  • Apache 2.0 license header has been added to every new source file (using spotless)

🧪 How to Test Locally

# 1. Build and run all tests (requires Docker for Testcontainers)
mvn verify

# 2. Check code style
mvn spotless:check

@github-actions

Copy link
Copy Markdown
Contributor

📋 Unreleased Changelog Preview

This is what the next release notes will look like based on commits in this PR.

Changelog

All notable changes to this project will be documented in this file.

[Unreleased]

✨ Features

  • Update plugin version handling and improve logging

⬆️ Dependency Updates

  • Bump com.azure:azure-storage-blob in the azure group (deps)@dependabot[bot]

Generated by git-cliff


🔄 Run #83 · Sun, 20 Sep 2026 19:35:34 GMT

@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Results

Metric Count
Passed 103
Failed 0
⏭️ Skipped 0
📊 Total 103

✅ Coverage

Type Coverage Covered / Total
📏 Lines 80.8% 287 / 355
🌿 Branches 64.8% 92 / 142
🔧 Methods 95.5% 64 / 67

🔄 CI run #88 · Sun, 20 Sep 2026 19:37:59 GMT

@nil-malh
nil-malh merged commit 3765719 into main Sep 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant