fix(rocm): distinguish CUDA and ROCm in the MTP policy cache key - #1933
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
Non-Apple hosts used to share the hardware label Unknown-0c, so a CUDA verdict was reused on ROCm. Prefix the backend (and architecture when present) on non-Apple hosts. Leave the Apple spelling unchanged and do not migrate old hint files: they record no vendor, so a mapping would guess. Closes lablup#1887
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-Apple hosts used to share the hardware label `Unknown-0c`, so a CUDA MTP policy verdict was reused on ROCm. `hardware_label()` now prefixes backend identity (`cuda` / `rocm`, plus architecture when present) on non-Apple hosts. Apple labels stay unchanged. Old `Unknown-0c` hint files are not migrated (they record no vendor).
Closes #1887
Test plan