Add check for correct closing method of html element - #505
Open
RoyaltyInTraining wants to merge 2 commits into
Open
Add check for correct closing method of html element#505RoyaltyInTraining wants to merge 2 commits into
RoyaltyInTraining wants to merge 2 commits into
Conversation
html_unchecked! macro can be used to skip checks
|
Does this enable optionally closing regular tags like void elements? |
Author
No, it only helps developers to write correct code by highlighting mistakes. I know that some people want the added syntax, but since this is my first contribution to this project, I chose to not touch the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses problems which multiple issues have mentioned (#432, #474).
The problem is: Block elements closed with
;and void elements closed with{}currently generate invalid HTML. Especially the block elements which are missing their closing tags can easily cause unexpected results after the browser attempts to silently fix the error.This PR adds simple validation logic which emits errors when a mismatch is detected. It uses the current list of void elements in the HTML living standatd. The generation logic wasn't changed, so the output of valid usage remains identical. A
html_uncheckedmacro is also included as an escape hatch.