fix: implement QueryBuilder search across searchable columns - #5
Merged
Merged
Conversation
search() previously had no effect because applySearch() was empty. - Add searchable(array|string) to register columns to search. - applySearch() matches the trimmed term with a contains LIKE, OR'd across columns inside a nested where group; blank/null term is a no-op. - Escape %, _ and \ in the term and use an explicit ESCAPE '\' clause so escaping works on sqlite/pgsql as well as mysql. - Dot-notation columns whose prefix is a relation (e.g. author.name) are searched via orWhereHas; otherwise treated as a plain/qualified column. - Add feature tests for matching, blank no-op, multi-column OR, nesting, escaping and relation search. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
QueryBuilder::search()had no effect:applySearch()was an empty stub.Changes
searchable(array|string $columns)to register the columns to search (+getSearchableColumns()).applySearch()trims the term and matches%term%with LIKE, OR'd across columns inside a nestedwheregroup (so it doesn't break other constraints). Blank/null term, or no searchable columns, is a no-op.%,_and\in the term are escaped, with an explicitESCAPE '\'clause so escaping works on sqlite/pgsql as well as mysql.author.name) are searched viaorWhereHas; other dotted values are treated as table-qualified columns.Tests
New
tests/Feature/QueryBuilderSearchTest.php(sqlite): matching, blank no-op, no columns no-op, multi-column OR, nesting with an outer constraint, escaping of%,_,\, and relation search. Full suite: 126 passed. Pint clean.🤖 Generated with Claude Code