Skip to content

fix(tests): isolate SCIM bad-id test from shared postgres state - #2

Merged
TheusHen merged 1 commit into
mainfrom
fix/scim-test-isolation
Sep 20, 2026
Merged

TheusHen merged 1 commit into
mainfrom
fix/scim-test-isolation

Conversation

@TheusHen

Copy link
Copy Markdown
Member

Description

The go job failed in the Race step: TestSCIMBadID created its admin user with a fixed email while the same Postgres service had already been used by the earlier Test step, so the second pass died on duplicate key ... users_email_key. Every other API test already uses a timestamped email — this one was the odd one out. Also fixed the SC2035 glob in the release checksum step while I was in there.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested?

  • go vet ./internal/api/ — clean
  • go build ./... — clean
  • go test -run TestNothingMatchesThis ./internal/api/ — compiles, ok (full suite needs the Postgres service from CI)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

The Race step runs against the same database as the earlier Test
step, so the fixed scim-admin@t.local email blew up with a
duplicate-key error on the second pass. Use a unique email per run
like the other API tests do. Also fixed the SC2035 glob in the
release checksum step.
@TheusHen
TheusHen merged commit bd2b09c into main Sep 20, 2026
2 checks passed
@TheusHen
TheusHen deleted the fix/scim-test-isolation branch September 20, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant