fix(tests): isolate SCIM bad-id test from shared postgres state - #2
Merged
Merged
Conversation
The Race step runs against the same database as the earlier Test step, so the fixed scim-admin@t.local email blew up with a duplicate-key error on the second pass. Use a unique email per run like the other API tests do. Also fixed the SC2035 glob in the release checksum step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
gojob failed in the Race step:TestSCIMBadIDcreated its admin user with a fixed email while the same Postgres service had already been used by the earlierTeststep, so the second pass died onduplicate key ... users_email_key. Every other API test already uses a timestamped email — this one was the odd one out. Also fixed the SC2035 glob in the release checksum step while I was in there.Type of change
How has this been tested?
go vet ./internal/api/— cleango build ./...— cleango test -run TestNothingMatchesThis ./internal/api/— compiles, ok (full suite needs the Postgres service from CI)Checklist