feat: Add Auxiliary script test - #1700
jstoobysmith merged 6 commits into
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
|
Changes look good to me, one point for clarification -- if awaiting-author |
auxillary_script_test yes it will block it. But I think this is what we want. The only time this would ever really break is when bumping Physlib. |
|
--awaiting-author |
nateabr
left a comment
There was a problem hiding this comment.
Okay sounds good, I think this can be merged :)
Made with the help of Claude Opus 5.5.
AI Summary
Adds
lake exe auxillary_script_test, which runs and checks the scripts that generate the website data. It runs in CI, and CI now treats warnings and info messages as errors. The PR also fixes everything the stricter CI exposed: five "Try this" info messages and the declaration name clashes between PhyslibAlpha and Physlib/QuantumInfo.1. Auxiliary script test and CI
scripts/auxillary-script-test.lean(new,lean_exe auxillary_script_testinlakefile.toml) runsmake_tag,TODO_to_yml mkFile,stats mkHTMLandinformal mkFile mkDot mkHTML, and checks their output files..github/workflows/build.ymlabsorbsalphaBuild.yml, which is deleted. Both builds use--iofail(fail on warnings and info messages), and the new test runs once both builds pass.AGENTS.md,scripts/README.md,scripts/PhyslibAlpha/README.md, and the bump template.github/ISSUE_TEMPLATE/Bump.yml, whose four script checkboxes and manualrmstep become one item.2.
--iofailfixesring→ring_nfinAnalyticVector/Local.lean,Existence/GaussianKernelGrowth.leanandJordanOrderUnit/Examples/SpinFactor.lean(×2).abel→abel_nfinJordanOrderUnit/Operator.lean.3. Harmonic oscillator dedup
Physlib/QuantumMechanics/HarmonicOscillator/Basic.lean:potentialFunction_continuous(new): the potential function is continuous.potentialFunction_aestronglyMeasurable,potentialOperator_isSelfAdjoint: previouslyinformal_lemmas, now proved (the proofs come from PhyslibAlpha).PhyslibAlpha/QuantumMechanics/HarmonicOscillator/LadderSystem.lean(new):toLadderSystem: the lowering and raising operators as aLadderSystem.toLadderSystem_N_toLinearMap: its number operators arenumberCLM.PhyslibAlpha/QuantumMechanics/HarmonicOscillator/Basic.leanandLadderOperators.lean, which duplicated Physlib:annihilationCLM/creationCLMare Physlib'sloweringCLM/raisingCLM, andnumberCLMand the commutation relations exist in Physlib.PhyslibAlpha/QuantumMechanics/HarmonicOscillator/Vacuum.lean:annihilationCLM_vacuumGaussian→loweringCLM_vacuumGaussian, andannihilationCLM_stdGaussian_of_xi_eq_one→loweringCLM_stdGaussian_of_xi_eq_one.4.
ProbabilisticTheorynamespacePhyslibAlpha/ProbabilisticTheoryandPhyslib/ProbabilisticTheorymoves intonamespace ProbabilisticTheory. This fixes the clash between PhyslibAlpha'sPOVMand QuantumInfo's.selfAdjoint,LinearPMap,PositiveLinearMap,unitary,StarAlgEquiv,BoundedMeasurable) stays in those types' namespaces so dot notation keeps working. Where needed it uses_root_.X.foo.open ProbabilisticTheoryinPhyslibAlpha/CondensedMatter/TightBindingChain/Uncertainty.lean.Reviewer map
Look at each commit separately don't look at overall files changed.
Checks run locally
lake build -KCI --iofailandlake build -KCI --iofail PhyslibAlphalake exe auxillary_script_test(all four scripts pass)runPhyslibAlphaLinters,alphaFileImports,alphaPythonLinters.sh,check_file_importspython scripts/api_map_linter.py --repo .🤖 Generated with Claude Code