feat: caller-chosen claim visibility on submit (private | unlisted) - #28
Merged
Conversation
verify / verify_and_wait / verify_batch / verify_batch_and_wait accept
visibility='private' (default) or 'unlisted' (readable by verification_id
and at /c/, never listed). Batch items may set per-item visibility to
override the batch-wide default. Omit-when-empty keeps existing request
bodies byte-identical for current callers.
Verification.visibility returns 'private' | 'unlisted' | 'public' so
callers can read back what they set ('public' is read-only, for listed
claims). Matches the /api/v1 contract in lenzhq/Lenz#111.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GUotnFnktv9yWTFce8cQpW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
visibilityto the verify family, matching the new/api/v1contract (lenzhq/Lenz#111).verify/verify_and_wait/verify_batch/verify_batch_and_waitacceptvisibility="private"(default, owner-only) orvisibility="unlisted"(readable byverification_idand at the/c/URL, but never listed).visibilityto override the batch-wide default.visibilitykwarg → no key in the request body, so existing callers are byte-identical and the server applies itsprivatedefault.Verification.visibilityreturns"private" | "unlisted" | "public"for read-back ("public"is read-only, for genuinely listed claims).Tests
tests/test_client.py: default-omits-visibility, sends-when-set, batch batch-wide + per-item override.test_client.py+test_contract.pygreen.Not included
Node SDK +
/developersdocs are deferred until a real external caller needs them (zero organic API callers today).🤖 Generated with Claude Code
https://claude.ai/code/session_01GUotnFnktv9yWTFce8cQpW