Conversation
Add PgUp and PgDn handlers for paging through rows in the main statistics view while keeping the table header visible. Preserve the current snapshot during redraws, clamp the vertical offset after filtering, refresh, and terminal resize, and retain the horizontal column position. Add tests for page offsets, filtered rows, redraw behavior, header rendering, horizontal offset preservation, and the PgUp/PgDn handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large statistics views in
pgcenter topcould not be fully inspected whenthe result contained more rows than fit in the terminal.
This change adds vertical pagination using
PgUpandPgDn:Validation
make testmake build21917PgDn→PgDn→PgUpwith a result exceeding terminal heightFollow-up
Horizontal scrolling remains on the existing
viewChredraw path. It isoutside the scope of this change, but could be migrated to the dedicated
redrawChpath in a follow-up change.AI assistance: OpenAI Codex was used to assist with the implementation and tests. The changes were reviewed and validated by the author.