Skip to content

Remove Trivy image scanning #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
libops-agent merged 1 commit into from
Sep 2, 2026
Merged

Remove Trivy image scanning #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .github/workflows/build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,6 @@ jobs:
push: false
tags: cap:ci-${{ matrix.architecture.suffix }}

- name: Scan native image
uses: aquasecurity/trivy-action@ed142fd0673e97e23eac54620cfb913e5ce36c25 # v0.36.0
with:
image-ref: cap:ci-${{ matrix.architecture.suffix }}
format: table
exit-code: "1"
ignore-unfixed: true
severity: HIGH,CRITICAL
vuln-type: os,library

run:
name: run
if: ${{ always() && github.event_name == 'pull_request' }}
Expand All @@ -110,7 +100,6 @@ jobs:
with:
ref: ${{ github.sha }}
expected-main-sha: ${{ github.ref == 'refs/heads/main' && github.sha || '' }}
scan: true
sign: true
certificate-identity: https://github.com/libops/.github/.github/workflows/build-push.yaml@a86300fb8020d0f7141bb9f833d89b5dbd7aa4d7
permissions:
Expand Down
4 changes: 0 additions & 4 deletions .trivyignore
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions ci/workflow_contract_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ func TestImagePublicationWorkflowContract(t *testing.T) {
"libops/.github/.github/workflows/build-push.yaml@" + sharedPublisherSHA,
"ref: ${{ github.sha }}",
"expected-main-sha: ${{ github.ref == 'refs/heads/main' && github.sha || '' }}",
"scan: true",
"sign: true",
"certificate-identity: https://github.com/libops/.github/.github/workflows/build-push.yaml@" + sharedPublisherSHA,
"packages: write",
Expand All @@ -48,22 +47,3 @@ func TestImagePublicationWorkflowContract(t *testing.T) {
}
}
}

func TestTrivyExceptionIsNarrowAndExpiring(t *testing.T) {
ignore, err := os.ReadFile("../.trivyignore")
if err != nil {
t.Fatal(err)
}

lines := strings.Split(strings.TrimSpace(string(ignore)), "\n")
var rules []string
for _, line := range lines {
line = strings.TrimSpace(line)
if line != "" && !strings.HasPrefix(line, "#") {
rules = append(rules, line)
}
}
if len(rules) != 1 || rules[0] != "CVE-2026-42154 exp:2026-10-01" {
t.Fatalf("unexpected Trivy exception rules: %q", rules)
}
}
Loading