Add opt-in protectAllExtensions to challenge routes with dotted URLs [minor] - #109
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joecorall
changed the title
Contributor
Author
|
Thank you @joecorall ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A site that we support has Drupal content with path aliases containing dots. Bots were getting to the content because of the
protectFileExtensionslogic. There were more than 150 pseudo-extensions (really just the content in the path after the last dot) that we would have needed to protect. So instead of trying to enumerate all of the potentially growing list of "extensions", protecting all extensions seems like a suitable option.This PR introduces a
protectAllExtensionsconfiguration that when set to true (defaults to false for backwards compatibility), will apply protection logic to file-like paths.