fix(devin-cli): stop sending a permission mode the CLI rejects

[lidge-jun]

Summary

The devin-cli provider could not complete a single turn in its default configuration. The adapter passed DEVIN_PERMISSION_MODE=ask whenever OPENCODEX_DEVIN_CLI_ALLOW_TOOLS was unset — the default, and the path most operators are on — and the CLI rejects that value outright:

ERROR: stream disconnected before completion: Devin CLI exited (code 2) before
answering the prompt: error: invalid value 'ask' for '--permission-mode
<PERMISSION_MODE>': Invalid permission mode: ask. Valid options: normal (auto),
accept-edits, dangerous (yolo, bypass), autonomous (requires --sandbox)

normal is the CLI's own refuse-by-default mode, so the intent the ask value was reaching for is preserved exactly. The tools-allowed branch (bypass) is untouched.

Why no test caught it

tests/providers/devin-cli-adapter.test.ts drives the adapter through an injected spawn, and the fake child accepts any environment. The value is only validated by the real binary, so this is reachable only from a live run.

Verification

Devin CLI 3000.10.21 installed and signed in (devin auth status reports logged in), provider configured against the running proxy:

Before — five retries, every one exited (code 2).

After:

$ codex exec -m devin-cli/swe-2 "reply with exactly: DEVINCLI-OK"
DEVINCLI-OK
tokens used  18,343

GET /v1/models lists all 11 devin-cli/* rows.

Repository-wide bun run test and bun run typecheck: NOT RUN locally, per the operator constraint for this session. CI covers them on this head.

Checklist

• Targets dev
• Fix proven by a live turn against the real CLI
• Local full suite / typecheck (deferred to CI by operator instruction)

Summary by CodeRabbit

• Bug Fixes
  • Fixed Devin CLI interactions failing when tool access is restricted.
  • Updated permission handling to use a valid CLI mode, allowing turns to complete successfully.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-12T02:51:55.723629Z	2c6c2dc	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 51b3a467-e8a5-42ae-a5a3-112d493230f9

📥 Commits

Reviewing files that changed from the base of the PR and between dbad475 and 2c6c2dc.

📒 Files selected for processing (1)

• src/adapters/devin-cli/adapter.ts

---

📝 Walkthrough

Walkthrough

The Devin CLI adapter now passes DEVIN_PERMISSION_MODE=normal when tools are disabled. The change replaces the invalid ask value, which caused the CLI to exit with code 2.

Changes

Devin CLI permission mode

Layer / File(s)	Summary
Correct permission mode passed to the CLI src/adapters/devin-cli/adapter.ts:122-133	The adapter changes DEVIN_PERMISSION_MODE from ask to normal when tools are not allowed. The comment documents the valid modes and the exit code 2 failure caused by ask.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/devin-cli-permission-mode

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

⚠️ Deterministic hygiene checks failed.

• missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c6c2dc1db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Add regression coverage for the permission-mode mapping

The default-mode fix remains untested: the injected spawn in tests/providers/devin-cli-adapter.test.ts currently ignores its options, but it can capture options.env.DEVIN_PERMISSION_MODE without requiring the real CLI. As written, restoring ask or introducing another rejected value would leave all focused tests green while breaking every default-configured live turn again. Add assertions that the default path passes normal and that the tools-enabled path preserves its intended bypass/override behavior.

AGENTS.md reference: src/AGENTS.md:L24-L25

Useful? React with 👍 / 👎.

[lidge-jun]

리뷰 · 우선순위 74 / 80

이 PR은 devin-cli 어댑터가 기본 설정에서 한 턴도 못 끝내던 문제를 고칩니다. 도구 허용이 꺼진 기본 경로(대부분의 운영자가 쓰는 경로)에서 어댑터가 DEVIN_PERMISSION_MODE=ask를 넣고 있었는데, Devin CLI 3000.10.21은 ask를 거부하고 code 2로 바로 죽습니다. 유효 값은 normal(auto), accept-edits, dangerous(yolo/bypass), autonomous(sandbox 필요)뿐입니다.

지금 dev HEAD(e7f7487b3)에는 이미 이 변경이 들어가 있습니다. src/adapters/devin-cli/adapter.ts에서 tools 미허용일 때 normal을 쓰고, tools 허용 분기는 예전처럼 bypass(또는 환경변수 오버라이드)를 유지합니다. normal이 CLI 쪽 “기본은 거절” 모드라서, 원래 ask로 의도했던 안전 쪽 의미는 그대로입니다. 라이브 턴으로 codex exec -m devin-cli/swe-2가 응답까지 간 것도 PR 본문에 적혀 있습니다.

왜 단위 테스트가 못 잡았는지도 분명합니다. tests/providers/devin-cli-adapter.test.ts는 spawn을 주입하고, 가짜 child는 env를 검증하지 않습니다. 실제 바이너리만 ask를 거부하므로 기본 경로 회귀는 라이브 CLI나 env 스냅샷 테스트가 있어야 보입니다. hygiene 봇이 missing_regression_test로 막은 이유도 그 지점입니다.

현재 dev 맥락에서는 #4330 Grok 리셋 쿠폰 GUI, #4326/#4323 Devin 라벨·컨텍스트 윈도우, #4322 shared icon/preset 위에 얹힌 한 줄짜리 치명 버그 수정입니다. 라우팅 재설계가 아니라 기본 운영 경로를 살리는 핫픽스라 우선순위가 높습니다. 패키지 버전은 여전히 2.52.0입니다.

머지는 이미 끝났고, 남은 건 테스트 구멍과 라벨(intake: hygiene-blocked) 정리 여부입니다. 후속으로 spawn env에 DEVIN_PERMISSION_MODE가 tools 미허용일 때 normal인지 단언하는 작은 테스트를 넣으면 hygiene와 회귀가 같이 닫힙니다.

라인 133 - tools 미허용일 때 DEVIN_PERMISSION_MODE가 normal인지 단언하는 회귀 테스트가 아직 없습니다. 가짜 spawn은 아무 env나 받으므로 예전 ask 회귀를 CI가 다시 못 잡습니다.
tests/providers/devin-cli-adapter.test.ts - 주입 spawn이 env를 검사하지 않아 실바이너리만 잡는 실패 모드가 테스트 사각지대입니다.
PR 라벨 intake: hygiene-blocked - 머지 후에도 hygiene 실패 라벨이 남아 있으면 열린 PR 큐/필터가 헷갈릴 수 있습니다(이미 MERGED).

메인테이너의 판단이 필요한 지점

• 이미 dev에 올라간 핫픽스에 대해 test-exception-approved로 hygiene를 사후 승인할지, 아니면 env 단언 테스트 follow-up PR을 받을지
• tools 허용 분기에서 운영자가 DEVIN_PERMISSION_MODE를 잘못된 값으로 넣었을 때 CLI exit 2를 더 친절한 에러로 감쌀지(이번 PR 범위 밖)

너의 추천

• 내용은 맞고 이미 dev에 랜딩됨. 별도 리버트 불필요.
• 가능하면 바로 이어서 spawn env 스냅샷 테스트 한 건을 작은 PR로 올려 missing_regression_test를 닫고, 남은 intake: hygiene-blocked 라벨은 정리.
• Local-tab 카탈로그 스택(docs(devlog): roadmap for the add-provider catalog unified search, note clamp and Local tab #4324/feat(gui): give local providers their own tab in the add-provider catalog #4325)과는 무관하니 그 기차와 섞지 말 것.

이 댓글은 grok-bot이 작성했습니다

[github-actions]

⏳ DRAFT

• hygiene: missing_regression_test.

What to do

• Fix missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.