fix(responses): preserve raw content and provider summary provenance - #4345
fix(responses): preserve raw content and provider summary provenance#4345lidge-jun wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Co-authored-by: Robin Bially <7304732+RobinBially@users.noreply.github.com> Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com> Co-authored-by: Eran <earan@localhost>
41aa8a5 to
97a7d9c
Compare
리뷰 · 우선순위 49 / 80이 PR은 Responses에서 raw reasoning은 content 채널에 두고, summary 이벤트는 provider가 쓴 요약만 쓰게 맞춘다. Antigravity/CCA Gemini는 클라이언트가 preference를 생략하면 요약을 켜는 기본을 시드하고, wire #4301과 #4287을 한 계약으로 모은 carry다. 클라이언트가 “생략”으로 직렬화하면 “명시적 none”과 구분이 안 된다는 한계를 본문이 인정한다. 테스트 면은 bridge raw hidden, google adapter/compiler, reasoning summary passthrough/rewrite, show-thinking-summary, combo failover, xAI chat reasoning 등 넓다. 로컬 스위트 미실행· 경로/심볼 - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Summary
Keep raw reasoning on the Responses content channel and reserve summary presentation for provider-authored summaries. Reconciles #4301 and #4287: the Antigravity provider default enables CCA Gemini summaries when the client omits the preference, while explicit wire
reasoning.summary: "none"and configured providerfalseretain their meaning. A client that serializes its preference as omission cannot be distinguished. Raw DeepSeek/Chat content is never promoted into summary events, and native Responses replay retains its original representation.CCA summary classification is request-local and Gemini-only; direct Google/Vertex and unknown model provenance retain their prior classification. Tool signatures remain independent of display. The change does not alter client settings, the running service or Spark retirement.
Carries source work from #4301 and #4287, with corrected contract and additional streaming, opt-out, fallback and signature regression coverage. Source PRs remain open for coordinator disposition after integration. Independent ordinary PR; base dev, no native stack.
Verification
git diff --check: passed; static whitespace inspection only.git push --no-verify. No merge or auto-merge is authorized here.Checklist
Co-authored-by: Robin Bially 7304732+RobinBially@users.noreply.github.com
Co-authored-by: yxr1995-maker 257504378+yxr1995-maker@users.noreply.github.com
Co-authored-by: Eran earan@localhost
Current head:
97a7d9c0f8b9ae3dae9ce87c439e4e84a5564216, rebased ontoe4ee8c54b0d3dcf5d245aea4589d608bf118c9c3. Independent implementation review and resolution-only re-audit PASS; source/tests patch equivalent. Document conflict preserves new continuation recovery alongside native raw-content representation. Local product checks NOT RUN; final refreshed hosted CI pending.