fix(extensions): validate model registration - #233
Conversation
|
Thanks for this, the design looks solid and the test coverage is impressive. Quick question before I approve: did you actually run a generation with trellis2 on this branch ? It's the one official extension with no setup.py (just build_vendor.py + a committed vendor/), so after this PR it stays on the direct/proxy path permanently, it can never get a venv. Two things I couldn't verify by reading:
If you've tested it and both work, let me know and I'll drop it. Otherwise that's the scenario I'd want checked before merge. |
|
Thanks — I tested the current functional Trellis2 GGUF extension at commit d707382 in a completely isolated environment on PR #233. I exercised the real FastAPI reload and cancellation routes. Reload registered both nodes with no errors, and cancellation returned HTTP 200 in 0.86 ms, reached the cancelled state, and produced zero legacy proxy/context activations. Lazy imports also occur inside the extension subprocess using its own venv, so restoring the manager’s sys.path does not affect this GGUF extension. I want to be precise about the limit: I could not complete a real GLB generation on this ARM64 GB10 machine. Trellis2’s setup exits 0, but the required cumesh and flex_gemm wheels are unavailable for ARM64. Registration and the worker ready handshake succeed, but generation readiness does not. That appears to be an existing Trellis2 GGUF setup/platform issue rather than a regression from this PR. |
Fixes #232
Summary
Key changes
sys.pathValidation
npm test— 47 Python and 110 Node tests passed in the configured Modly development environmentnpm run lintnpm run buildgit diff --check upstream/dev --upstream/devbaseline