Skip the broken Stainless csharp SDK target so spec PRs stop failing CI#656
Skip the broken Stainless csharp SDK target so spec PRs stop failing CI#656ls-bolt[bot] wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
📌 Bolt Status 2026-07-06 23:49:36 UTC — ⚡ Agent |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-python studio · code · diff
✅ grid-csharp studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Folded in from #656 so this PR's preview check goes green on its own. Co-Authored-By: mohamedwane <mohamedwane@users.noreply.github.com> Co-Authored-By: benwgold <benwgold@users.noreply.github.com>
…the Card resource (#657) ## Summary Follow-up #2 from [webdev#29877](lightsparkdev/webdev#29877) (Lithic card PAN-reveal POC), evolved per review: PAN reveal is now an **explicit, dedicated endpoint** rather than a side effect of reading the card. Server change: [webdev#29995](lightsparkdev/webdev#29995). - **New `POST /cards/{id}/reveal`** (`openapi/paths/cards/cards_{id}_reveal-session.yaml` + `CardRevealResponse` schema) — mints a signed, short-lived reveal URL and returns `{ panEmbedUrl, expiresAt }`. Every mint is audit-logged with the requesting actor; unattributable sessions get 403. - **`panEmbedUrl` is removed from the `Card` schema entirely** — get/list/create/update responses and webhook payloads never carry it. A live PAN-reveal credential only exists when a client explicitly asked for one (least-privilege + clean "reveal requested" audit semantics). - **Docs rewritten to the reveal-session flow**: issuing-cards gains the `POST …/reveal` example, quickstart/webhooks/terminology snippets updated, webhook examples no longer show the field, and `GET /cards/{id}` points at the reveal endpoint. - **Rode along from the folded #656**: a small `GtqAccountInfoBase` description clarification. `.stainless/stainless.yml` is byte-identical to main (the csharp experiments were fully reverted; the real csharp fix is #663). ## Verification - `make build` + `make lint` pass (0 errors; remaining warnings pre-exist on main). - Server implementation is TDD'd end-to-end on [webdev#29995](lightsparkdev/webdev#29995) (58 handler/proxy tests + dashboard dialog tests green). ## CI note — red `preview` check is expected until #663 merges The Stainless csharp target's upstream build CI fails on any codegen delta (content-independent); the fix is #663 (removes the unpublished csharp target on main). Until it merges, `preview` stays red on spec-changing PRs, this one included — merge through it (precedent #633, #637). Details: [investigation](#657 (comment)). --- 🤖 [thundering-graviton-5](https://zeus.dev.dev.sparkinfra.net/#/arc?id=thundering-graviton)[(#5)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=thundering-graviton-5) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: mohamedwane <mohamedwane@users.noreply.github.com> Co-authored-by: benwgold <benwgold@users.noreply.github.com> Co-authored-by: pengying <pengying@users.noreply.github.com>

Summary
The
Build SDKs for pull request / preview(andmerge) check has been failing on every spec-changing PR since Jul 6 (window opened Jul 3–6) with:A bisect on throwaway PR #650 proved the failure is content-independent: even a field-description-only change (doc-comment codegen delta, zero structural change) fails, while diffs with no generated-csharp delta pass via Stainless's build cache. Recent casualties: #644 (merged red), #646 (twice), #641.
This PR sets
skip: trueon the csharp target in.stainless/stainless.yml(schema-documented option: "Skip generation for this target"), so csharp is excluded from preview/merge builds and the check reflects the targets we actually ship.Why skipping is safe:
production_repo: null,publish.nuget: false— nothing consumes itskip: truere-enables it once the upstream build CI is fixedcsharp.2025-10-08is the only csharp edition (no bump available),diagnostics.ignoreddoesn't cover build-CI outcomes, and the workflow-levelfail_onknob isn't per-languageValidation in this PR: it also carries a one-word GTQ
bankNamedescription change — exactly the kind of doc-comment-only codegen delta that reliably failed csharp in the bisect. Thepreviewcheck on this PR passing IS the end-to-end test that the skip fixes the failure mode. (If preferred, I can drop the GTQ tweak before merge — but it's a harmless doc improvement, so I'd leave it.)The real csharp error is only visible in Stainless Studio (org
lightspark, projectgrid→ csharp build diagnostics) — worth a look / a Stainless support ticket by someone with access, especially given Stainless's hosted generator is winding down post-acquisition and build-env rot may recur on other unpublished targets.Slack thread: https://lightsparkgroup.slack.com/archives/D0BCM1RUHHU/p1783372549749679
Test plan
make build+make lint-openapiclean (errors=0; warnings pre-existing)previewcheck on this PR is the test: it fails on main for any codegen-delta diff (proven in [CI bisect — do not review] INR schema change minus rail property #650), so it passing here proves the skip works🤖 bonded-titan-2(#2) | Feedback