Skip to content

Skip the broken Stainless csharp SDK target so spec PRs stop failing CI#656

Closed
ls-bolt[bot] wants to merge 2 commits into
mainfrom
07-06-skip-broken-stainless-csharp-target
Closed

Skip the broken Stainless csharp SDK target so spec PRs stop failing CI#656
ls-bolt[bot] wants to merge 2 commits into
mainfrom
07-06-skip-broken-stainless-csharp-target

Conversation

@ls-bolt

@ls-bolt ls-bolt Bot commented Jul 6, 2026

Copy link
Copy Markdown

Claim this PR — take ownership under your GitHub account

Summary

The Build SDKs for pull request / preview (and merge) check has been failing on every spec-changing PR since Jul 6 (window opened Jul 3–6) with:

csharp: Your SDK build had a failure in the build CI job, which is a regression from the base state.

A bisect on throwaway PR #650 proved the failure is content-independent: even a field-description-only change (doc-comment codegen delta, zero structural change) fails, while diffs with no generated-csharp delta pass via Stainless's build cache. Recent casualties: #644 (merged red), #646 (twice), #641.

This PR sets skip: true on the csharp target in .stainless/stainless.yml (schema-documented option: "Skip generation for this target"), so csharp is excluded from preview/merge builds and the check reflects the targets we actually ship.

Why skipping is safe:

  • csharp is unpublished: production_repo: null, publish.nuget: false — nothing consumes it
  • the config block stays in place; deleting skip: true re-enables it once the upstream build CI is fixed
  • the alternatives don't work: csharp.2025-10-08 is the only csharp edition (no bump available), diagnostics.ignored doesn't cover build-CI outcomes, and the workflow-level fail_on knob isn't per-language

Validation in this PR: it also carries a one-word GTQ bankName description change — exactly the kind of doc-comment-only codegen delta that reliably failed csharp in the bisect. The preview check on this PR passing IS the end-to-end test that the skip fixes the failure mode. (If preferred, I can drop the GTQ tweak before merge — but it's a harmless doc improvement, so I'd leave it.)

The real csharp error is only visible in Stainless Studio (org lightspark, project grid → csharp build diagnostics) — worth a look / a Stainless support ticket by someone with access, especially given Stainless's hosted generator is winding down post-acquisition and build-env rot may recur on other unpublished targets.

Slack thread: https://lightsparkgroup.slack.com/archives/D0BCM1RUHHU/p1783372549749679

Test plan


🤖 bonded-titan-2(#2) | Feedback

@ls-bolt ls-bolt Bot added the bolt label Jul 6, 2026
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jul 6, 2026 11:55pm
grid-wallet-demo Ignored Ignored Preview Jul 6, 2026 11:55pm

Request Review

@ls-bolt

ls-bolt Bot commented Jul 6, 2026

Copy link
Copy Markdown
Author

📌 Bolt Status

2026-07-06 23:49:36 UTC — ⚡ Agent linked-prism(#1) started


Feedback

akanter commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

csharp

docs(api): clarify BankName as beneficiary's bank in GTQ models

go

docs(api): clarify BankName field description in GTQ external account

kotlin

docs(api): clarify bankName as beneficiary's bank in GTQ account models

openapi

docs(api): remove C# code samples, update bankName description

php

docs(types): clarify bankName field description in GTQ account models

python

docs(api): clarify bank_name description in gtq_external_account_create_info

ruby

docs(types): clarify bank_name field in gtq models

typescript

docs(types): clarify bankName field description in GTQ account models

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

grid-ruby studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

grid-go studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@b63507d011a5768ce502b6fc00f9f3b0c74924b7
grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ❗

grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ✅

npm install https://pkg.stainless.com/s/grid-typescript/3abd5d2796d4c806b17f0af2f651d6785518bfba/dist.tar.gz
grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/9569897ee3cf238dc4d1a13e6743e68064bd556f/grid-0.0.1-py3-none-any.whl
grid-csharp studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ❗lint ✅test ❗

grid-php studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅lint ✅test ✅

grid-cli studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ❗lint ❗test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-06 23:59:02 UTC

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ls-bolt Bot pushed a commit that referenced this pull request Jul 7, 2026
Folded in from #656 so this PR's preview check goes green on its own.

Co-Authored-By: mohamedwane <mohamedwane@users.noreply.github.com>
Co-Authored-By: benwgold <benwgold@users.noreply.github.com>
@ls-bolt

ls-bolt Bot commented Jul 7, 2026

Copy link
Copy Markdown
Author

Folded into #657 (commit 0bc4ba1) per ben's request to merge the two into one PR — the csharp skip: true and the GTQ bankName description change both carried over verbatim. Closing this one; #656's branch can be deleted.


🤖 radiant-quark(#1) | Feedback

@ls-bolt ls-bolt Bot closed this Jul 7, 2026
@ls-bolt ls-bolt Bot deleted the 07-06-skip-broken-stainless-csharp-target branch July 7, 2026 01:18
benwgold added a commit that referenced this pull request Jul 8, 2026
…the Card resource (#657)

## Summary

Follow-up #2 from
[webdev#29877](lightsparkdev/webdev#29877)
(Lithic card PAN-reveal POC), evolved per review: PAN reveal is now an
**explicit, dedicated endpoint** rather than a side effect of reading
the card. Server change:
[webdev#29995](lightsparkdev/webdev#29995).

- **New `POST /cards/{id}/reveal`**
(`openapi/paths/cards/cards_{id}_reveal-session.yaml` +
`CardRevealResponse` schema) — mints a signed, short-lived reveal URL
and returns `{ panEmbedUrl, expiresAt }`. Every mint is audit-logged
with the requesting actor; unattributable sessions get 403.
- **`panEmbedUrl` is removed from the `Card` schema entirely** —
get/list/create/update responses and webhook payloads never carry it. A
live PAN-reveal credential only exists when a client explicitly asked
for one (least-privilege + clean "reveal requested" audit semantics).
- **Docs rewritten to the reveal-session flow**: issuing-cards gains the
`POST …/reveal` example, quickstart/webhooks/terminology snippets
updated, webhook examples no longer show the field, and `GET
/cards/{id}` points at the reveal endpoint.
- **Rode along from the folded #656**: a small `GtqAccountInfoBase`
description clarification. `.stainless/stainless.yml` is byte-identical
to main (the csharp experiments were fully reverted; the real csharp fix
is #663).

## Verification

- `make build` + `make lint` pass (0 errors; remaining warnings
pre-exist on main).
- Server implementation is TDD'd end-to-end on
[webdev#29995](lightsparkdev/webdev#29995) (58
handler/proxy tests + dashboard dialog tests green).

## CI note — red `preview` check is expected until #663 merges

The Stainless csharp target's upstream build CI fails on any codegen
delta (content-independent); the fix is #663 (removes the unpublished
csharp target on main). Until it merges, `preview` stays red on
spec-changing PRs, this one included — merge through it (precedent #633,
#637). Details:
[investigation](#657 (comment)).

---
🤖
[thundering-graviton-5](https://zeus.dev.dev.sparkinfra.net/#/arc?id=thundering-graviton)[(#5)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=thundering-graviton-5)
| [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: mohamedwane <mohamedwane@users.noreply.github.com>
Co-authored-by: benwgold <benwgold@users.noreply.github.com>
Co-authored-by: pengying <pengying@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants