Remove the broken Stainless csharp target so spec PRs stop failing CI#663
Remove the broken Stainless csharp target so spec PRs stop failing CI#663ls-bolt[bot] wants to merge 1 commit into
Conversation
Stainless's csharp build CI fails on any freshly generated code (content-independent, proven by bisect on #650), and the preview check gates on head-vs-base regression per language — so every spec-changing PR fails 'Build SDKs' while main's config still lists csharp and the base build resolves to a cached pre-breakage success. With csharp gone from the config on main, base builds have no csharp success to regress from and the check passes (proven end-to-end by probe #659, which ran the exact previously-failing change class against a csharp-free base and passed). The target is unpublished (production_repo: null, no NuGet publish), so nothing ships differently. Re-add the block when Stainless fixes their csharp build CI upstream. This PR's own preview check will still be red (its base is current main) — merge through it; precedent #633, #637. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-cli studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-csharp studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
…#671) ## Summary Removes the csharp target from `.stainless/stainless.yml` so the `Build SDKs for pull request / preview` check stops failing on every spec-changing PR. **Why every spec PR is red**: Stainless's csharp build CI is broken upstream for ANY freshly generated code (content-independent, proven by bisect on #650, breakage window ~Jul 3). The preview check gates on a per-language head-vs-base regression, and with csharp in main's config the base build resolves to a cached pre-breakage csharp *success* — so every fresh head failure counts as a regression → red. **Why this fixes it**: with csharp out of the config on main, base builds have no cached csharp success to regress from — matching outcomes on base and head → "not a regression" → green. Proven end-to-end by probe #659: the exact previously-failing change class (doc-comment-only codegen delta) ran against a csharp-free base and `preview` **passed**. Full mechanics: [investigation writeup](#657 (comment)). **No shipping impact**: the csharp target is unpublished (`production_repo: null`, `publish.nuget: false`). Re-add the block when Stainless fixes their csharp build CI upstream. ## Sequencing (for #657 and other open spec PRs) 1. Merge this PR — **its own `preview` will be red** (its base is current main); merge through it (precedent: #633, #637). 2. Merge/rebase main into open spec PRs (e.g. #657) — their next `preview` run goes green. ## Verification - `make lint` passes; the file matches the exact removal previously validated on the #657 branch (commit 069ad9a) and by probe #659. --- 🤖 [thundering-graviton-3](https://zeus.dev.dev.sparkinfra.net/#/arc?id=thundering-graviton)[(#3)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=thundering-graviton-3) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) Original PR: #663 Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…the Card resource (#657) ## Summary Follow-up #2 from [webdev#29877](lightsparkdev/webdev#29877) (Lithic card PAN-reveal POC), evolved per review: PAN reveal is now an **explicit, dedicated endpoint** rather than a side effect of reading the card. Server change: [webdev#29995](lightsparkdev/webdev#29995). - **New `POST /cards/{id}/reveal`** (`openapi/paths/cards/cards_{id}_reveal-session.yaml` + `CardRevealResponse` schema) — mints a signed, short-lived reveal URL and returns `{ panEmbedUrl, expiresAt }`. Every mint is audit-logged with the requesting actor; unattributable sessions get 403. - **`panEmbedUrl` is removed from the `Card` schema entirely** — get/list/create/update responses and webhook payloads never carry it. A live PAN-reveal credential only exists when a client explicitly asked for one (least-privilege + clean "reveal requested" audit semantics). - **Docs rewritten to the reveal-session flow**: issuing-cards gains the `POST …/reveal` example, quickstart/webhooks/terminology snippets updated, webhook examples no longer show the field, and `GET /cards/{id}` points at the reveal endpoint. - **Rode along from the folded #656**: a small `GtqAccountInfoBase` description clarification. `.stainless/stainless.yml` is byte-identical to main (the csharp experiments were fully reverted; the real csharp fix is #663). ## Verification - `make build` + `make lint` pass (0 errors; remaining warnings pre-exist on main). - Server implementation is TDD'd end-to-end on [webdev#29995](lightsparkdev/webdev#29995) (58 handler/proxy tests + dashboard dialog tests green). ## CI note — red `preview` check is expected until #663 merges The Stainless csharp target's upstream build CI fails on any codegen delta (content-independent); the fix is #663 (removes the unpublished csharp target on main). Until it merges, `preview` stays red on spec-changing PRs, this one included — merge through it (precedent #633, #637). Details: [investigation](#657 (comment)). --- 🤖 [thundering-graviton-5](https://zeus.dev.dev.sparkinfra.net/#/arc?id=thundering-graviton)[(#5)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=thundering-graviton-5) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: mohamedwane <mohamedwane@users.noreply.github.com> Co-authored-by: benwgold <benwgold@users.noreply.github.com> Co-authored-by: pengying <pengying@users.noreply.github.com>

Summary
Removes the csharp target from
.stainless/stainless.ymlso theBuild SDKs for pull request / previewcheck stops failing on every spec-changing PR.Why every spec PR is red: Stainless's csharp build CI is broken upstream for ANY freshly generated code (content-independent, proven by bisect on #650, breakage window ~Jul 3). The preview check gates on a per-language head-vs-base regression, and with csharp in main's config the base build resolves to a cached pre-breakage csharp success — so every fresh head failure counts as a regression → red.
Why this fixes it: with csharp out of the config on main, base builds have no cached csharp success to regress from — matching outcomes on base and head → "not a regression" → green. Proven end-to-end by probe #659: the exact previously-failing change class (doc-comment-only codegen delta) ran against a csharp-free base and
previewpassed. Full mechanics: investigation writeup.No shipping impact: the csharp target is unpublished (
production_repo: null,publish.nuget: false). Re-add the block when Stainless fixes their csharp build CI upstream.Sequencing (for #657 and other open spec PRs)
previewwill be red (its base is current main); merge through it (precedent: feat(openapi): add rail + settlement-timing fields to OutgoingTransaction #633, Add idType/identifier to IndividualCustomerCreateRequest (ENG-10686) #637).previewrun goes green.Verification
make lintpasses; the file matches the exact removal previously validated on the docs(cards): PAN reveal via POST /cards/{id}/reveal; panEmbedUrl off the Card resource #657 branch (commit 069ad9a) and by probe Probe: Stainless preview vs csharp-free base (throwaway) #659.🤖 thundering-graviton-3(#3) | Feedback