Skip to content

Text feature represents shaping and layout, and text parsing is enabled by default - #1128

Open
fundon wants to merge 2 commits into
linebender:mainfrom
fundon:text_layout_feature
Open

fundon wants to merge 2 commits into
linebender:mainfrom
fundon:text_layout_feature

Conversation

@fundon

@fundon fundon commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

The text feature represents shaping and layout, and text parsing is enabled by default.

@fundon
fundon marked this pull request as draft August 31, 2026 17:23
@fundon
fundon force-pushed the text_layout_feature branch from 13c4e5f to 9cd2c6d Compare August 31, 2026 17:25
@fundon
fundon force-pushed the text_layout_feature branch from 9cd2c6d to 4b745ce Compare August 31, 2026 17:33
@fundon
fundon marked this pull request as ready for review September 1, 2026 01:22
@nicoburns

Copy link
Copy Markdown
Collaborator

What does just text parsing involve? That sounds quite lightweight (is it just XML parsing + a typed representation?). I wonder if we could just have that always-on?

@fundon

fundon commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor Author

The text feature only provides the original text. If we have already used parley in some places, then we can focus on processing the text. At present, my scenario is to extract the original text and then hand it over to the unified parley for processing.

@nicoburns

nicoburns commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

Can we rework this to:

  • Remove the new text feature (the parsing functionality gated by it should just be always-enabled)
  • Rename the text-layout feature back to text

Also:

  • Ensure that resvg-capi either compiles without the text/text-layout feature or unconditionally enables it.

@fundon
fundon force-pushed the text_layout_feature branch from af549f3 to 0a4f023 Compare September 8, 2026 12:43
@fundon fundon changed the title Add text_layout feature for shaping and layout Refactor text feature Sep 8, 2026
@fundon fundon changed the title Refactor text feature Text feature represents shaping and layout, and text parsing is enabled by default Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants