tests: load test fonts in a deterministic order - #1136
Merged
DJMcNab merged 1 commit intoSep 16, 2026
Merged
Conversation
`fontdb::load_fonts_dir` walks the directory with `std::fs::read_dir`, which outputs entries in filesystem order. That order is not stable across machines, and the test harness depends on it. Replace `load_fonts_dir` with an explicit sorted list so order is identical everywhere. The whole suite passes unchanged, so no stored reference image depended on the previous ordering.
DJMcNab
approved these changes
Sep 16, 2026
DJMcNab
left a comment
DJMcNab
left a comment
Member
There was a problem hiding this comment.
Sure. Test code is low enough risk, especially if CI still passes...
This probably should use an unstable sort, but I can't be bothered fixing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fontdb::load_fonts_dirwalks the directory withstd::fs::read_dir, which outputs entries in filesystem order. That order is not stable across machines, and the test harness depends on it.Replace
load_fonts_dirwith an explicit sorted list so order is identical everywhere. The whole suite passes unchanged, so no stored reference image depended on the previous ordering.