usvg: allow building Tree programmatically (part 1: tree , path , group, fill, stroke) - #1137
Closed
mu-mostafa98 wants to merge 1 commit into
Closed
mu-mostafa98 wants to merge 1 commit into
mu-mostafa98 wants to merge 1 commit into
Conversation
Signed-off-by: Mohamed Mostafa <mu.mostafa98@gmail.com>
Collaborator
|
Sorry, but I'm not sure we are going to make the Giving users the ability to modify the tree arbitrarily could lead to unpredictable behavior because it might break assumptions we hold internally about the structure of the tree. It's definitely unfortunate, but given that we barely have any resources/time to maintain this library as is, I don't think it makes sense to attempt to expand the functionality provided even more. :( |
Collaborator
|
Yes, the tree is read-only by design. This cannot and will not be changed anytime soon. |
Author
|
Thank you for clarifying the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servo web engine builds
usvg::Treefrom XML, so only presentation attributes reach the renderer and the CSS cascade can't affect SVG (only inlinestyleworks).To honor post-cascade computed values, Servo needs to build the tree programmatically instead.
Changes
Made public
Group::empty()Path::new(...)Implemented
filldata membersstrokedata membersgroupdata membersid,opacityGroup::push_childTree::new(size, root)Stroke::default()Only the
usvgcrate changes;resvgis untouched.Later PRs add the remaining node kinds.