Conversation
Interpreting parts of a Mask as a "SubPixmapMut" was confusing because SubPixmapMut (typically) has 4-byte pixels, while Mask uses 1-byte pixels. The new GenericPixmapMut struct should also make it easier to handle non-u8888 pixel formats in the future.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpreting a region of a Mask as a
SubPixmapMutwas a bit confusing because SubPixmapMut (typically) has 4-byte pixels, while Mask uses 1-byte pixels. The new GenericPixmapMut struct should also make it easier to handle non-u8888 pixel formats in the future.