Conversation
LaurenzV
added this pull request to stack #1965
September 30, 2026 15:04
LaurenzV
marked this pull request as draft
October 1, 2026 09:30
laurenz-canva
force-pushed
the
laurenz/better_image
branch
from
October 1, 2026 10:58
ae66dc1 to
75250f7
Compare
laurenz-canva
removed this pull request from stack #1965
October 1, 2026 10:59
laurenz-canva
added this pull request to stack #1969
October 1, 2026 11:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, our image is a simple red pixmap. While this does help us find very obvious image sampling issues, it still feels a bit meaningless because... Well, it's all a single color. 😄 Therefore, this PR changes it to a different image which also has different results depending on whether nearest-neighbor or bilinear sampling is chosen.
Here the images since they are a bit hard to see in the preview:
I've tried this on a number of MacBooks and mobile devices and they all pass the probe correctly, so this shouldn't cause any big regressions, and hopefully will help us find more hidden issues, if certain devices have any.