Conversation
LaurenzV
commented
Oct 1, 2026
Collaborator
Author
There was a problem hiding this comment.
Since glyphs don't use bicubic anymore this test didn't test what it was supposed to test, hence why I replaced it with a new test, which exposes the same issue as #1563.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to move away from bicubic sampling, both because it's very slow since it doesn't have native GPU support, and because it also makes the shaders very big. We will likely still offer the option for people to choose it if desired, but at least internally, I think we should avoid using it.
Therefore, I would propose always using
Mediumimage quality when rendering bitmap glyphs. The original idea behind choosing bicubic was that it can make aliasing artifacts slightly better when downscaling a lot since we sample more surrounding pixels. However, it doesn't fix the fundamental issue: If you downscale a bitmap glyph by 6x, you are still going to get aliasing artifacts, they are just a slightly less worse, which is also noticeable if you look at some of the test images. The real solution to this problem is 1) Choose appropriate bitmap strikes (which we already do when possible and 2) apply mipmapping, which we currently can't.The reason this came up is that I'm working on feature-flagging bicubic sampling in the shader, and it would be nice if this wouldn't break glyph rendering.