fix: keep Type=forking behavior in dde-session-loader-wrapper - #228
fix: keep Type=forking behavior in dde-session-loader-wrapper#228felixonmars wants to merge 1 commit into
Conversation
The systemd service was changed to `Type=forking` in linuxdeepin@8b39a25, but the wrapper directly exec the original daemon, which hangs the systemd service indefinitely on Arch since we don't have deepin-security-loader. Let's stick to the fork-like behavior to fix this.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the session-loader wrapper to retain fork-style behavior required by the service’s Type=forking configuration, preventing the service from hanging on systems without deepin-security-loader. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 当前修复正确实现了 fallback 路径的 forking 行为。安全加载器路径的 exec 可能由 loader 自身处理 fork,建议确认 deepin-security-loader 是否内部 fork 后退出 2. 代码质量 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 建议在 exit 0 前添加注释说明 forking 行为 3. 代码性能 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: 无性能问题 4. 代码安全 🔒评价: 优秀 ✅ 通过
安全漏洞详情: 建议: 变量引用规范,无安全风险 💡 改进建议代码示例// 暂无代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felixonmars, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The systemd service was changed to
Type=forkingin 8b39a25, but the wrapper directly exec the original daemon, which hangs the systemd service indefinitely on Arch since we don't have deepin-security-loader.Let's stick to the fork-like behavior to fix this.
Summary by Sourcery
Bug Fixes: