Skip to content

fix: keep Type=forking behavior in dde-session-loader-wrapper - #228

Open
felixonmars wants to merge 1 commit into
linuxdeepin:masterfrom
felixonmars:patch-2
Open

fix: keep Type=forking behavior in dde-session-loader-wrapper#228
felixonmars wants to merge 1 commit into
linuxdeepin:masterfrom
felixonmars:patch-2

Conversation

@felixonmars

@felixonmars felixonmars commented Aug 31, 2026

Copy link
Copy Markdown
Member

The systemd service was changed to Type=forking in 8b39a25, but the wrapper directly exec the original daemon, which hangs the systemd service indefinitely on Arch since we don't have deepin-security-loader.

Let's stick to the fork-like behavior to fix this.

Summary by Sourcery

Bug Fixes:

  • Restore fork-like wrapper behavior so the Type=forking systemd service can start and remain managed correctly without deepin-security-loader.

The systemd service was changed to `Type=forking` in linuxdeepin@8b39a25, but the wrapper directly exec the original daemon, which hangs the systemd service indefinitely on Arch since we don't have deepin-security-loader.

Let's stick to the fork-like behavior to fix this.
@sourcery-ai

sourcery-ai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the session-loader wrapper to retain fork-style behavior required by the service’s Type=forking configuration, preventing the service from hanging on systems without deepin-security-loader.

File-Level Changes

Change Details Files
Restore fork-like process behavior in the session-loader wrapper so the systemd unit remains compatible with Type=forking.
  • Change the wrapper from directly replacing itself with the original daemon to launching it as a child/background process.
  • Preserve the wrapper’s role as the parent process expected by systemd when deepin-security-loader is unavailable.
misc/dde-session-loader-wrapper.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 98 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 98 分,大于 70 分通过阈值,代码质量符合要求。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 当前修复正确实现了 fallback 路径的 forking 行为。安全加载器路径的 exec 可能由 loader 自身处理 fork,建议确认 deepin-security-loader 是否内部 fork 后退出


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 建议在 exit 0 前添加注释说明 forking 行为


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无性能问题


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 变量引用规范,无安全风险


💡 改进建议代码示例

// 暂无代码示例

本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars, fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants