Fix incorrect country labels and flags when coloring neighboring countries - #2190
Open
nithinshiju-dev wants to merge 1 commit into
Open
nithinshiju-dev wants to merge 1 commit into
nithinshiju-dev wants to merge 1 commit into
Conversation
Contributor
Author
|
@llaske I tracked the issue to the click hitTolerance. Setting it to 0 instead of 4 prevents neighboring countries from being selected during normal clicks. The only remaining edge case is clicking exactly on the shared border, where both countries may still be detected due to the map geometry. Screen.Recording.2026-07-31.075155.mp4 |
Owner
|
@nithinshiju-dev did you test it on a touch device? I'm afraid reducing hit tolerance could have an impact on touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where clicking adjacent countries (for example, India and Bhutan) could display incorrect country labels and flags.
The issue was caused by the click hit tolerance. With
hitToleranceset to4, clicks near country borders could match neighboring features. Reducing it to0ensures that only the intended country is selected.Changes
hitTolerancefrom4to0inactivities/ColorMyWorld.activity/lib/map.js.Testing
Fixes #2179