fix(wtrlab): send genre ids in the filter, not slugs - #2561
Open
ShakeyHands91 wants to merge 3 commits into
Open
ShakeyHands91 wants to merge 3 commits into
ShakeyHands91 wants to merge 3 commits into
Conversation
ShakeyHands91
force-pushed
the
master
branch
from
September 24, 2026 18:09
650ff53 to
9e7ff49
Compare
|
| id = 'WTRLAB'; | ||
| name = 'WTR-LAB'; | ||
| site = 'https://wtr-lab.com/'; | ||
| version = '1.2.2'; |
There was a problem hiding this comment.
This adds the new genre values and version bump to a root-level file, but the production build excludes root-level files and discovers plugins under plugins/english/. The existing plugins/english/wtrlab.ts still uses version 1.2.1 and slug-valued genres. As a result, users will continue to receive the old plugin and genre filtering will remain broken. Apply the change to the existing plugin file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
type(scope): descriptionCloses #2510
Genre filtering silently returns unfiltered results
The
novel-finderendpoint expects numeric genre ids ingi. The pluginsends slugs, which the server ignores — so filtering by genre returns the
full listing, which reads as "the filter does nothing". This is the
behaviour reported in #2510.
Measured against the live endpoint:
gi=action&gc=and— what the plugin sends todaygi=1&gc=andti=417&tc=andti=417,20&tc=andSo
gi,gc, the exclusion params and comma-joining were all correctalready; only the values were wrong. That also explains why tag filtering
worked and genre filtering didn't — the tag options were already numeric
ids.
The mapping
Genre ids are the 1-based alphabetical positions of the option list
already in the plugin. 32 of the 40 were read directly from the genre
chip links the site renders on novel pages (
/en/novel-list?genre=<id>).The remaining 8 — Ecchi, Erciyuan, Mecha, Shoujo, Smut, Sports, Tragedy,
Wuxia — were each verified individually: filter by the id, open a novel
from the results, confirm the rendered name matches and that the novel
carries that id in
serie_data.genres. All 40 check out.Tag options are already numeric ids and are untouched.
Scope
One change plus the version bump —
1.2.1→1.2.2. Nothing else in thefile is modified; the chapter-title heading from #2538 and the
translation-mode work from #2525 are left exactly as they are.