Skip to content

fix(wtrlab): send genre ids in the filter, not slugs - #2561

Open
ShakeyHands91 wants to merge 3 commits into
lnreader:masterfrom
ShakeyHands91:master
Open

ShakeyHands91 wants to merge 3 commits into
lnreader:masterfrom
ShakeyHands91:master

Conversation

@ShakeyHands91

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description

Closes #2510


Genre filtering silently returns unfiltered results

The novel-finder endpoint expects numeric genre ids in gi. The plugin
sends slugs, which the server ignores — so filtering by genre returns the
full listing, which reads as "the filter does nothing". This is the
behaviour reported in #2510.

Measured against the live endpoint:

query results
(no filter) 94754
gi=action&gc=and — what the plugin sends today 94754 — ignored
gi=1&gc=and 66647 — applied
ti=417&tc=and 77061 — tags already worked
ti=417,20&tc=and 407 — comma-joined ids work

So gi, gc, the exclusion params and comma-joining were all correct
already; only the values were wrong. That also explains why tag filtering
worked and genre filtering didn't — the tag options were already numeric
ids.

The mapping

Genre ids are the 1-based alphabetical positions of the option list
already in the plugin. 32 of the 40 were read directly from the genre
chip links the site renders on novel pages (/en/novel-list?genre=<id>).
The remaining 8 — Ecchi, Erciyuan, Mecha, Shoujo, Smut, Sports, Tragedy,
Wuxia — were each verified individually: filter by the id, open a novel
from the results, confirm the rendered name matches and that the novel
carries that id in serie_data.genres. All 40 check out.

Tag options are already numeric ids and are untouched.

Scope

One change plus the version bump — 1.2.1 → 1.2.2. Nothing else in the
file is modified; the chapter-title heading from #2538 and the
translation-mode work from #2525 are left exactly as they are.

@ShakeyHands91 ShakeyHands91 reopened this Sep 24, 2026
@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR should not merge as the filtering fix will not reach users.

Findings

  1. P1 Genre fix will not ship ▶

Summary

The PR adds a root-level copy of WTR-LAB with numeric genre filter values and a version bump, rather than updating the existing plugin.

  • The production build excludes the added file, leaving the intended filtering fix unpublished.

Reviews (1) · Last reviewed commit: "Add files via upload"

Comment thread wtrlab.ts Outdated
id = 'WTRLAB';
name = 'WTR-LAB';
site = 'https://wtr-lab.com/';
version = '1.2.2';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Genre fix will not ship

This adds the new genre values and version bump to a root-level file, but the production build excludes root-level files and discovers plugins under plugins/english/. The existing plugins/english/wtrlab.ts still uses version 1.2.1 and slug-valued genres. As a result, users will continue to receive the old plugin and genre filtering will remain broken. Apply the change to the existing plugin file.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wtr lab

1 participant