Skip to content

fix(dreamyTranslations): Hide locked chapters setting not working - #2569

Merged
rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
SupremeMango:dreamy-hide-locked
Sep 24, 2026
Merged

rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
SupremeMango:dreamy-hide-locked

Conversation

@SupremeMango

@SupremeMango SupremeMango commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Closes #2494

Summary

Adds a "Hide locked chapters" toggle to the Dreamy Translations plugin.

When enabled, chapters marked as premium/locked are filtered out of the
chapter list returned by parseNovel. The setting is read from LNReader's
storage API at runtime.

Changes

  • Read hideLocked from storage inside parseNovel (not from pluginSettings.value) anymore lol
  • Filter out chapters where free === false when the setting is on
  • Bump version 1.1.0 → 1.1.1

Known Limitation

Due to LNReader's current behavior of retaining chapters that disappear
from a plugin's response
(see #1352), enabling the toggle will not remove
already-cached locked chapters for novels already in the library.

Workaround for Users

Delete the novel from the library and re-add it (or clear the app's data) so parseNovel runs against a fresh chapter list.

That method didnt' work for me but I did tested like this

  • Backup my novels in settings
  • Clear the whole lnreader's app data
  • Enable the setting before OPENING the plugin.
  • It should hope the locked chapters

But when we restore the backup especially if you are testing agaist the novel that you've read, it kinda doesn't work. It is related to #1352, maybe you can experiment with backup options.

And please don't turn setting off if you wnat to continue reading with hide chapter setting on, for example

You click a new fresh novel A that you have never clicked before -> toggle on -> it works
Toggle off -> check same novel -> it works but
Toggle on again -> check the same novel -> it doesn't work now, bc LNReader's chapter DB never deletes chapters that disappear from a plugin's response

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR appears safe to merge, though the premium-access advice should be clarified for existing library entries.

Findings

  1. P2 Misleading advice for cached chapters ▶

Summary

The PR makes Dreamy Translations read the hide-locked setting from storage when parsing a novel, bumps the plugin version, and expands the premium-access error message.

  • The setting lookup follows the documented runtime pattern.
  • The new error advice does not account for locked chapters retained in an existing library entry.

Reviews (1) · Last reviewed commit: "fix(dreamyTranslations): Hide locked cha..."

Comment on lines +423 to +424
'This chapter requires premium access and cannot be read here. ' +
'You can enable "Hide locked chapters" in the plugin settings to filter out locked chapters.',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Misleading advice for cached chapters When a locked chapter is already cached in a reader’s library, this error can still appear after they enable the setting. LNReader retains chapters that disappear from the plugin’s response, so the suggested toggle will not remove that chapter. Please qualify the advice for existing library entries.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@rajarsheechatterjee
rajarsheechatterjee merged commit b8604e7 into lnreader:master Sep 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dreamy Translations hide locked chapters

3 participants