Skip to content

IWYU: Tests and more Common cleanup - #2982

Draft
jwrober wants to merge 5 commits into
longturn:masterfrom
jwrober:refactor/iwyu-tests
Draft

IWYU: Tests and more Common cleanup#2982
jwrober wants to merge 5 commits into
longturn:masterfrom
jwrober:refactor/iwyu-tests

Conversation

@jwrober

@jwrober jwrober commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Part of #2464

@jwrober

jwrober commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Stuck on

helpdata.cpp:459:18: warning: no header providing "QT_VERSION_STR" is directly included [misc-include-cleaner]
   71 |                  QT_VERSION_STR, qVersion());
      |                  ^

@jwrober

jwrober commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Also

common/scriptcore/tolua_common_a_gen.cpp:19:1: warning: no header providing "LUALIB_API" is directly included [misc-include-cleaner]
    6 | 
    7 | #ifndef __cplusplus
    8 | #include <stdlib.h>
    9 | #endif
   10 | #ifdef __cplusplus
   11 |  extern "C" int tolua_bnd_takeownership (lua_State* L); // from tolua_map.c
   12 | #else
   13 |  int tolua_bnd_takeownership (lua_State* L); /* from tolua_map.c */
   14 | #endif
   15 | #include <string.h>
   16 | 
   17 | /* Exported function */
   18 | TOLUA_API int tolua_common_a_open (lua_State* tolua_S);
   19 | LUALIB_API int luaopen_common_a (lua_State* tolua_S);
      | ^

with similar message for tolua_signal_gen.cpp and tolua_game_gen.cpp

@lmoureaux lmoureaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • QT_VERSION_STR is provided by QtConfig and QtVersionChecks
  • LUALIB_API comes from luaconf.h

Comment thread data/tests/rulesets.cpp.in Outdated
Comment thread server/tests/cli.cpp.in Outdated
Comment thread utility/tests/test_paths.cpp Outdated
@jwrober

jwrober commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author
  • QtVersionChecks

Adding this does not resolve the clang-tidy check error message in helpdata.cpp

@jwrober
jwrober force-pushed the refactor/iwyu-tests branch from 7980b62 to 0df7fcb Compare September 9, 2026 02:23
@jwrober

jwrober commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Still need to look at LUALIB_API. Tests prolly need to be excluded from further checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants