fix(tmwebdriver): preserve exception chain in _remote_cmd ConnectionError#663
Open
Kailigithub wants to merge 1 commit into
Open
fix(tmwebdriver): preserve exception chain in _remote_cmd ConnectionError#663Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_remote_cmdmethod in TMWebDriver catches connection errors and re-raises with a user-friendly message, but discards the original exception. Addingas e+from epreserves the causal chain in the traceback, making it easier to diagnose whether the failure was a DNS issue, a refused connection, or a timeout.Changes
as e) and chain it (from e)Two-line change. The user-facing error message is unchanged; only the traceback depth improves.
Verification
py_compile TMWebDriver.py— passesruff check TMWebDriver.py --select=B904— passes (was the only B904 in the file)