tui: combine status bar's page/web/id onto one line - #650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the terminal dashboard's status bar layout reported in #647.
Before, the pager hint and web link each sat on their own bare, unstyled line below the status bar, separated from it and each other by a blank gap line, and the instance id shared the first (colored) line with the job counts.
Now:
Rendered output (colors stripped for the text capture, background/underline verified separately in tests):
Changes
ui.go: fuse the id/pager/web cells into one status-bar-styled line (renderStatusInfoLine), reusingrenderStatusBar's cyclic cell coloring; underline the web link with a style matching its cell's background/foreground (underlineSpanStyle), since a nested Lipgloss span resets its parent's style; adjustjobsPerPage/visibleJobschrome accounting now that the info line no longer costs its own gap line.ui_test.go: update tests for the new id placement and "web:" label, add tests for the merged/gap-free line and the underline span style.CHANGELOG.md: add an unreleased entry.Tests
go test ./...passes.go vet ./...andgofmt -l .are clean.Closes #647
Agents: claude-code (claude-sonnet-5)