Skip to content

feat: update orbitalSim and provider to receive the defaultZoom value as a prop #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffinnes merged 1 commit into from
Jun 2, 2026
Merged

feat: update orbitalSim and provider to receive the defaultZoom value as a prop #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/epo-widget-lib/src/mock-data/OrbitalSim/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export const SwappableOrbitsData = {
atira,
amor
],
defaultZoom: 3
},
swappableOrbits: true
}
Expand Down Expand Up @@ -58,7 +57,6 @@ export const PrimaryData = {
selectionCallback: () => {},
paused: true,
pov: "top",
defaultZoom: 3,
potentialOrbits: null,
observations: null,
noDetails: true,
Expand Down Expand Up @@ -18090,7 +18088,6 @@ export const PotentialOrbitsData = {
selectionCallback: () => {},
paused: null,
pov: null,
defaultZoom: 3,
potentialOrbits: true,
observations: [
{
Expand Down Expand Up @@ -18250,7 +18247,6 @@ export const ObjectDetailsData = {
selectionCallback: () => {},
paused: null,
pov: null,
defaultZoom: 3,
potentialOrbits: null,
observations: null,
detailsSet: "hazardous-asteroids",
Expand Down
3 changes: 2 additions & 1 deletion packages/epo-widget-lib/src/widgets/OrbitalSim/Context/OrbitalSimContext.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { ReactNode } from "react";
export interface OrbitalSimProviderProps {
children: ReactNode,
orbitData: Orbits,
defaultZoom: number,
showDetailsTable?: boolean,
allowOrbitRotation?: boolean,
showTimeControls?: boolean,
Expand All @@ -14,6 +15,7 @@ export interface OrbitalSimProviderProps {

export type OrbitalSimContextValues = {
orbits: Orbits;
defaultZoom: number;
showDetailsTable?: boolean;
allowOrbitRotation?: boolean;
showTimeControls?: boolean;
Expand Down Expand Up @@ -56,7 +58,6 @@ export type Orbits = {
observations: Observation[],
paused: boolean,
pov: string | null,
defaultZoom: number | null,
potentialOrbits: boolean,
noDetails: boolean,
refObjs: string[] | null,
Expand Down
4 changes: 3 additions & 1 deletion packages/epo-widget-lib/src/widgets/OrbitalSim/Context/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export function useOrbitalSimContext() {
export function OrbitalSimProvider({
children,
orbitData,
defaultZoom,
showDetailsTable=false,
allowOrbitRotation=false,
showTimeControls=false,
Expand All @@ -58,7 +59,6 @@ export function OrbitalSimProvider({
observations: [],
paused: false,
pov: null,
defaultZoom: null,
potentialOrbits: false,
noDetails: false,
refObjs: null,
Expand Down Expand Up @@ -95,6 +95,7 @@ export function OrbitalSimProvider({

const values: OrbitalSimContextValues = useMemo(() => ({
orbits,
defaultZoom,
showDetailsTable,
allowOrbitRotation,
showTimeControls,
Expand All @@ -106,6 +107,7 @@ export function OrbitalSimProvider({
selectedNeoIndex
}),[
orbits,
defaultZoom,
showDetailsTable,
allowOrbitRotation,
showTimeControls,
Expand Down
9 changes: 9 additions & 0 deletions packages/epo-widget-lib/src/widgets/OrbitalSim/OrbitalSim.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ import { PrimaryData, PotentialOrbitsData, ObjectDetailsData, SwappableOrbitsDat
const meta: Meta<typeof OrbitalSim> = {
component: OrbitalSim,
parameters: { r3f: true },
args: {
defaultZoom: 0.5,
},
argTypes: {
defaultZoom: {
control: { type: 'number', step: 0.01 },
},
},
};
export default meta;

Expand All @@ -24,6 +32,7 @@ const Template: StoryFn<typeof OrbitalSim> = (args:any ) => {
{args.observations && <SelectionList sources={ selectedAnswer ? [{ type: "observation", id: selectedAnswer}] : [] } onRemoveCallback={ resetSelectedAnswer }/>}
<OrbitalSimProvider
orbitData={args.orbits}
defaultZoom={args.defaultZoom}
selectedAnswer={selectedAnswer}
updateSelectedAnswer={setSelectedAnswer}
showDetailsTable={args.showDetailsTable}
Expand Down
6 changes: 2 additions & 4 deletions packages/epo-widget-lib/src/widgets/OrbitalSim/OrbitalSim.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,20 @@ import { useOrbitalSimContext } from "./Context/index.js";
import { Neo } from "./Context/OrbitalSimContext.types.js"

function OrbitalSim() {
const { orbits, showDetailsTable, allowOrbitRotation, showTimeControls, swappableOrbits, selectedNeoIndex }= useOrbitalSimContext();
const { orbits, defaultZoom, showDetailsTable, allowOrbitRotation, showTimeControls, swappableOrbits, selectedNeoIndex }= useOrbitalSimContext();
const {
paused,
pov,
defaultZoom,
potentialOrbits,
} = orbits;

const speeds = { min: 0.00001157, max: 365.25, initial: 11.574, step: 1 };
const [playing, setPlaying] = useState(!paused);
const [stepDirection, setStepDirection] = useState(1);
const [frameOverride, setFrameOverride] = useState(0);
const [dayPerVizSec, setDayPerVizSec] = useState(paused ? 0 : speeds.initial);
const [elapsedTime, setElapsedTime] = useState(0);
const [reset, setReset] = useState(0);
const [zoomLevel, setZoomLevel] = useState(1);
const [zoomLevel, setZoomLevel] = useState(defaultZoom);
const [currentSwappableOrbit, setCurrentSwappableOrbit] = useState({ neos: [ { Principal_desig: "" }]});

useEffect(() => {
Expand Down
Loading