Skip to content

fix: correct the type definitions for the orbital sim context provider - #461

Merged
jeffinnes merged 1 commit into
develop-react-v19from
ji-445-correct-OrbitalSimProviderProps-types
Jun 3, 2026
Merged

jeffinnes merged 1 commit into
develop-react-v19from
ji-445-correct-OrbitalSimProviderProps-types

Conversation

@jeffinnes

@jeffinnes jeffinnes commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

What this change does

Resolves #445

This PR corrects the type definitions for the orbital sim context provider by making the ones that are only needed for use in the question version of the widget optional.

Notes for reviewers

This is a level 3 review

  • 0 = "This is an FYI heads up to get your eyes on this"
  • 1 = "I barely need review on this"
  • 5 = "Please make sure there are no obvious errors and that you believe it does what it says it does"
  • 10 = "I think it works, I can explain how, but only over screenshare"

Testing

To verify this works:

  1. yarn link the epo-widget-lib package into the investigations-client
  2. Verify Typescript isn't flagging the prop errors on OrbitalSimProvider in components/content-blocks/OrbitalSim/OrbitalSimWidget.tsx or components/questions/Widget/OrbitalSim/index.tsx
  3. Verify that question and non-question orbital sims still work correctly.

Confirm the following testing is complete:

  • Testing the package builds successfully
  • Testing the component in isolation in its own story(ies)
  • Testing the component in any stories for widgets or other components that use it
  • Testing the component in the target client, if possible/feasible
  • Testing the target client builds successfully

Making the ones that are only needed for use in the question version of the widget optional.
@jeffinnes
jeffinnes requested a review from soshwosh June 3, 2026 14:34
@jeffinnes
jeffinnes merged commit b8faf94 into develop-react-v19 Jun 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants