Harden LED configuration and color packing#94
Open
mjc wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the LED driver’s handling of LED strip color order/encoding by validating configuration earlier and making color packing/shifting behavior well-defined for 32-bit output values.
Changes:
- Reject invalid
LedColorOrdervalues duringled_driver_setup()before calculating/allocating the DMA bitbuffer, with an error that identifies the offending strip index. - Make color channel bit packing explicitly use
uint32_twidening before shifts to avoid undefined behavior on 32-bit targets. - Reject unexpected
color_orderencodings in the paint path (added adefaultcase in the switch).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukash
reviewed
Jul 19, 2026
mjc
force-pushed
the
refloat-fix-led-driver-encoding
branch
from
July 20, 2026 18:42
a235ded to
8ae1c33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate LED strip color order before allocating DMA storage and report which strip is invalid.
The paint path also rejects unexpected encodings, and channel values are widened before bit packing. Valid GRB, GRBW, RGB, and WRGB output is unchanged.