Skip to content

[WRONG BRANCH] test(config): preserve child readiness diagnostics - #477

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-fail-fast-path-stderr-consumption-issue
Draft

[WRONG BRANCH] test(config): preserve child readiness diagnostics#477
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-fail-fast-path-stderr-consumption-issue

Conversation

@luvs01

@luvs01 luvs01 commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A readiness helper consumed child.stderr on early exit, which prevented callers from reading the same single-consumption stream and masked the original diagnostics.

Description

  • Stop consuming child.stderr in waitForOwnedChildReady, preserving the exit code and marker-path diagnostic without disturbing the stream.
  • Add a regression test readiness failure leaves child stderr available to its caller that forces a child to exit and verifies the readiness error message and that callers can still read child.stderr.
  • The change is confined to the test harness (tests/config/config-mutation-lock.test.ts) and preserves existing behavior for non-failure paths.

Testing

  • Ran bun test tests/config/config-mutation-lock.test.ts --test-name-pattern 'readiness failure leaves child stderr available', which passed.
  • Ran bun run typecheck and git diff --check, both of which succeeded.
  • Ran the full file tests bun test tests/config/config-mutation-lock.test.ts; 27 tests passed and 1 test failed due to an unrelated environment limitation in Bun 1.2.14 (node:zlib zstdDecompressSync export), not caused by this change.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T02:35:30.313189Z a475c6a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9c3e5207-3a99-4cda-8325-4fe7f8b39921


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore label Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title test(config): preserve child readiness diagnostics [WRONG BRANCH] test(config): preserve child readiness diagnostics Sep 10, 2026
@github-actions
github-actions Bot marked this pull request as draft September 10, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant