[WRONG BRANCH] test(config): preserve child readiness diagnostics - #477
[WRONG BRANCH] test(config): preserve child readiness diagnostics#477luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
child.stderron early exit, which prevented callers from reading the same single-consumption stream and masked the original diagnostics.Description
child.stderrinwaitForOwnedChildReady, preserving the exit code and marker-path diagnostic without disturbing the stream.readiness failure leaves child stderr available to its callerthat forces a child to exit and verifies the readiness error message and that callers can still readchild.stderr.tests/config/config-mutation-lock.test.ts) and preserves existing behavior for non-failure paths.Testing
bun test tests/config/config-mutation-lock.test.ts --test-name-pattern 'readiness failure leaves child stderr available', which passed.bun run typecheckandgit diff --check, both of which succeeded.bun test tests/config/config-mutation-lock.test.ts; 27 tests passed and 1 test failed due to an unrelated environment limitation in Bun 1.2.14 (node:zlibzstdDecompressSyncexport), not caused by this change.Codex Task