Skip to content

[WRONG BRANCH] fix(responses): isolate Cursor combo shadow calls - #480

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-combo-shadow-call-isolation-issue
Draft

[WRONG BRANCH] fix(responses): isolate Cursor combo shadow calls#480
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-combo-shadow-call-isolation-issue

Conversation

@luvs01

@luvs01 luvs01 commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Motivation

  • An early shadow-call rewrite that rewrote the request to a combo caused the combo dispatcher to return before the late shadow-intercept branch could set Cursor helper isolation, allowing combo children to inherit the parent Cursor conversation ID.
  • The intent is to preserve the combo failover behavior while ensuring helper calls dispatched via a shadow-to-combo replacement still get a fresh isolated Cursor conversation.

Description

  • Add shadowCallIntercepted?: boolean to HandleResponsesOptions and a local shadowCallIntercepted flag to record early shadow-to-combo rewrites.
  • When the code rewrites a request model into a combo selector, set shadowCallIntercepted = true and pass it into handleComboResponses so every concrete child attempt carries the interception marker.
  • When parsing the (child) request, apply Cursor isolation by setting parsed._cursorIsolateConversation = true when options.shadowCallIntercepted === true, ensuring a fresh Cursor conversation is used for intercepted helpers.
  • Add a regression test that verifies the marker is carried through the combo dispatch and the parsed handoff sets the isolation flag, and integrate that test into the existing shadow-intercept test file.

Testing

  • Ran the focused test: node_modules/bun/bin/bun.exe test tests/responses/responses-shadow-intercept.test.ts, which passed (24 tests in that file passed under the repository Bun runtime).
  • Ran type checking with bun run typecheck (invoked as PATH="$PWD/node_modules/bun/bin:$PATH" bun run typecheck) and bun run privacy:scan; both completed successfully.
  • Attempted a full bun run test; the run exposed unrelated, environment-dependent failures (older Bun runtime mismatch for a zstd API and a few system-dependent test failures); these are not regressions caused by these changes and the focused tests and typecheck passed.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:00:18.583360Z a15b2b0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 758aa25f-534e-4883-9048-b8e9943b333e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix(responses): isolate Cursor combo shadow calls [WRONG BRANCH] fix(responses): isolate Cursor combo shadow calls Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft September 11, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant