[WRONG BRANCH] fix(responses): isolate Cursor combo shadow calls - #480
[WRONG BRANCH] fix(responses): isolate Cursor combo shadow calls#480luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
shadowCallIntercepted?: booleantoHandleResponsesOptionsand a localshadowCallInterceptedflag to record early shadow-to-combo rewrites.modelinto a combo selector, setshadowCallIntercepted = trueand pass it intohandleComboResponsesso every concrete child attempt carries the interception marker.parsed._cursorIsolateConversation = truewhenoptions.shadowCallIntercepted === true, ensuring a fresh Cursor conversation is used for intercepted helpers.Testing
node_modules/bun/bin/bun.exe test tests/responses/responses-shadow-intercept.test.ts, which passed (24 tests in that file passed under the repository Bun runtime).bun run typecheck(invoked asPATH="$PWD/node_modules/bun/bin:$PATH" bun run typecheck) andbun run privacy:scan; both completed successfully.bun run test; the run exposed unrelated, environment-dependent failures (older Bun runtime mismatch for a zstd API and a few system-dependent test failures); these are not regressions caused by these changes and the focused tests and typecheck passed.Codex Task