[WRONG BRANCH] fix(web-search): bind continuations to initial API key - #484
[WRONG BRANCH] fix(web-search): bind continuations to initial API key#484luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Closing this original proposal after reimplementing its useful scope with current code and executable regression coverage. Follow-up now belongs to the submitted implementation and its review/CI; this closure does not claim the change has merged. |
Motivation
Description
selectionBoundContinuationDispatchinsrc/server/responses/core.tsto enforce that a continuation uses the same provider selection that served the first leg and to fail closed if the selection changed.dispatchOverrideuse fromoauthDispatch(request)toselectionBoundContinuationDispatch(request)so continuation sends cannot rebuild under a new key.tests/web-search/web-search-passthrough-bridge.test.tsthat mutates the configured API key during the hosted search and verifies the bridged continuation fails closed and does not reach the replacement account.src/server/responses/core.tsandtests/web-search/web-search-passthrough-bridge.test.ts.Testing
node_modules/bun/bin/bun.exe test tests/web-search/web-search-passthrough-bridge.test.ts, which passed (22 passed / 0 failed).PATH="$PWD/node_modules/bun/bin:$PATH" bun run typecheck, which succeeded.PATH="$PWD/node_modules/bun/bin:$PATH" bun run privacy:scan, which succeeded.PATH="$PWD/node_modules/bun/bin:$PATH" bun run test) and observed unrelated environment-dependent failures (150 failures across other tests); the focused regression remains green and was validated by the focused test run.Codex Task