Skip to content

[WRONG BRANCH] fix(catalog): account for auxiliary model charges - #486

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-free-only-filter-classification-issue
Draft

[WRONG BRANCH] fix(catalog): account for auxiliary model charges#486
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-free-only-filter-classification-issue

Conversation

@luvs01

@luvs01 luvs01 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Discovered pricing classification previously considered only prompt/input and completion/output token rates and could mark a model free while other published pricing dimensions (e.g. request, image, web_search) were positive.
  • The change enforces the intended fail-closed behavior so that any recognized positive pricing component classifies a model as paid, and unsupported or malformed auxiliary components yield unknown rather than erroneously free.

Description

  • Update discoveredPricingStatus in src/codex/catalog/provider-fetch.ts to inspect all fields on the provider pricing object via discoveredPricingRate, returning "paid" if any numeric component is greater than zero, "unknown" if any component is unusable, and "free" only when the required prompt/completion pair exists and every published numeric component is zero.
  • Clarify the function comment to reflect that auxiliary positive charges make a model paid and that unsupported shapes are treated as unknown.
  • Add regression tests in tests/codex-integration/catalog-free-pricing-status.test.ts covering positive per-request auxiliary pricing, fully-zero auxiliary dimensions, and unsupported/malformed auxiliary pricing shapes.

Testing

  • Ran the focused test file with bun test tests/codex-integration/catalog-free-pricing-status.test.ts, which passed all tests (13 pass, 0 fail).
  • Ran the TypeScript typecheck with bun x tsc --noEmit, which completed successfully.
  • Ran bun run privacy:scan, which passed and reported the modified files in the scan output.
  • bun run test:changed could not run in this environment because the checkout has no comparison ref (dev/origin/dev/upstream/dev), and git diff --check reported no issues.

Codex Task

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ba285dd9-a0f8-49dc-9e84-4382f533d279


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T01:33:39.376936Z 75e9a11 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
@github-actions github-actions Bot changed the title fix(catalog): account for auxiliary model charges [WRONG BRANCH] fix(catalog): account for auxiliary model charges Sep 12, 2026
@github-actions

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft September 12, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant